-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebAssembly Bookshelf to The Rust Bookshelf #58973
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @rust-lang/docs for adding a new entry to the bookshelf |
So, something that might cause a problem is that this doesn't add the wasm book to the doc distribution (EDIT: i.e. we don't build the wasm book(s) as part of |
Didn't we do this already? I am feeling very strong deja vu. And yes, we should be importing the actual book, not linking externally. Rustlings isn't a book; it's an interactive thing you run with cargo. With the |
We added the Embedded Book about a month ago in #56291 - maybe that's what you're remembering? |
It was certainly wasm. Maybe it was in-person conversations and not a PR directly. |
For my own understanding, why would is it preferred that bookshelf not be linked externally? I know it would be more effort for the team to extract the book into a submodule to import it into this bookshelf so I'm hoping to understand the motivation behind wanting to go that route. |
The Bookshelf and the local files created by It's worth noting that the Embedded WG also has several books, and only ships the "main" book in this bookshelf - all the others are kept on their own docs site. They have some prior discussion in rust-embedded/wg#257 that the Wasm WG could possibly crib from. |
We discussed this in the wasm working group meeting today & we are doing some work on The Rust Wasm Book. Since we'll be going the route of importing the book here, we can open a different PR when we are ready to add it to this bookshelf. Thanks! |
This PR adds a section for WebAssembly to the Specialize Rust section of The Rust Bookshelf.
This is a new change for the Rust and WebAssembly team in this PR: rustwasm/rustwasm.github.io#41