Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist-powerpc64le-linux: Update binutils version #58991

Closed
wants to merge 1 commit into from

Conversation

ajdlinux
Copy link

@ajdlinux ajdlinux commented Mar 7, 2019

Update to recent binutils to avoid a linker bug that causes crashes when
linking against OpenSSL.

Closes: #57345
Signed-off-by: Andrew Donnellan andrew.donnellan@au1.ibm.com


Hi, I'm a first time contributor!

I've been unable to test this, because for some reason I'm seeing a failure when running ./src/ci/docker/run.sh dist-powerpc64le-linux, with or without this patch, on two different machines, even though the ppc64le builds currently seem to be running fine in Travis.

   Compiling syntax_ext v0.0.0 (/checkout/src/libsyntax_ext)
[RUSTC-TIMING] syntax_ext test:false 59.344
rustc: /checkout/src/llvm-project/llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:1114: unsigned int {anonymous}::BitPermutationSelector::ValueBit::getValueBitIndex() const: Assertion `hasValue() && "Cannot get the value bit index of a constant bit"' failed.
[RUSTC-TIMING] rustc test:false 731.190
rustc exited with signal: 6
error: Could not compile `rustc`.

Would appreciate if someone else could test this + tell me what I'm doing wrong with running the CI scripts. It does appear to be fetching the new binutils tarball though.

Update to recent binutils to avoid a linker bug that causes crashes when
linking against OpenSSL.

Closes: rust-lang#57345
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2019
@ajdlinux
Copy link
Author

ajdlinux commented Mar 7, 2019

Dammit, I spent all day trying to get this to build, and didn't notice #58986. Thanks @cuviper for fixing it better :)

@ajdlinux ajdlinux closed this Mar 7, 2019
@cuviper
Copy link
Member

cuviper commented Mar 7, 2019

Hi @ajdlinux, sorry to have sniped your efforts!

I've been unable to test this, because for some reason I'm seeing a failure when running ./src/ci/docker/run.sh dist-powerpc64le-linux, with or without this patch, on two different machines, even though the ppc64le builds currently seem to be running fine in Travis.

The likely difference is that we have DEPLOY=1 set for Travis CI, which leave llvm-assertions in their default disabled state, as found here:

rust/src/ci/run.sh

Lines 47 to 57 in 88f755f

if [ "$DEPLOY$DEPLOY_ALT" != "" ]; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --release-channel=$RUST_RELEASE_CHANNEL"
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-static-stdcpp"
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.remap-debuginfo"
if [ "$NO_LLVM_ASSERTIONS" = "1" ]; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --disable-llvm-assertions"
elif [ "$DEPLOY_ALT" != "" ]; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-llvm-assertions"
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.verify-llvm-ir"
fi

But that assertion is worrying! I'll file a new bug about it, at least...

@ajdlinux
Copy link
Author

ajdlinux commented Mar 7, 2019

Haha I'm just glad someone else was looking at this, the broken cargo builds have been causing me a bit of grief in recent days. Thanks for opening the other issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants