Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renames EvalContext to InterpretCx #59430

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Renames EvalContext to InterpretCx #59430

merged 2 commits into from
Mar 28, 2019

Conversation

kenta7777
Copy link
Contributor

This PR renames EvalContext to InterpretCx in src/librustc_mir.
This PR is related to #54395 .

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2019
@kenta7777
Copy link
Contributor Author

r? @oli-obk

@oli-obk
Copy link
Contributor

oli-obk commented Mar 26, 2019

@bors r+

Thanks!

This will break miri. Would you be so kind and also open a PR against miri with these changes? You can test this out by running ./x.py test src/tools/miri, making all the changes necessary in src/tools/miri and then pushing to a fork of miri. The src/tools/miri is its own git repository, so you'll need to fork miri and point to your fork via git remote add mine git@github.com:kenta7777/miri.git

@bors
Copy link
Contributor

bors commented Mar 26, 2019

📌 Commit 630d5a4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 26, 2019

@bors r-

I just remembered: I think there are a bunch of docs and comments referring to EvalContext, can you change those, too?

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2019
@kenta7777
Copy link
Contributor Author

What docs and comments should I change? Could you show me specific examples of them?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 26, 2019

Basically search for EvalContext and make sure no more mentions of it exist. The other types with EvalContext within their name are fine for now, you can leave them as they are.

@kenta7777
Copy link
Contributor Author

Thanks. I renamed them in docs and comments. I think EvalContext does not exist in docs and comments at this point.

@kenta7777
Copy link
Contributor Author

I forked the miri repository and cloned it.
This search result is all uses of EvalContext in miri. Should I rename them to InterpretCx only ?

@oli-obk
Copy link
Contributor

oli-obk commented Mar 27, 2019

@bors r+ thanks!

in miri. Should I rename them to InterpretCx only ?

Yes, that would be great

@bors
Copy link
Contributor

bors commented Mar 27, 2019

📌 Commit 892f7c4 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 27, 2019
@kenta7777 kenta7777 mentioned this pull request Mar 27, 2019
Merged
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#59430 - kenta7777:rename-evalcontext-to-int…
f862792 
…erpretcx, r=oli-obk

Renames `EvalContext` to `InterpretCx`

This PR renames `EvalContext` to `InterpretCx` in `src/librustc_mir`.
This PR is related to rust-lang#54395 .
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#59430 - kenta7777:rename-evalcontext-to-int…
0ea791e 
…erpretcx, r=oli-obk

Renames `EvalContext` to `InterpretCx`

This PR renames `EvalContext` to `InterpretCx` in `src/librustc_mir`.
This PR is related to rust-lang#54395 .
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Mar 27, 2019
@Centril
Rollup merge of rust-lang#59430 - kenta7777:rename-evalcontext-to-int…
81201e2 
…erpretcx, r=oli-obk

Renames `EvalContext` to `InterpretCx`

This PR renames `EvalContext` to `InterpretCx` in `src/librustc_mir`.
This PR is related to rust-lang#54395 .
@Centril Centril mentioned this pull request Mar 27, 2019
Closed
cuviper added a commit to cuviper/rust that referenced this pull request Mar 28, 2019
@cuviper
Rollup merge of rust-lang#59430 - kenta7777:rename-evalcontext-to-int…
99f6de7 
…erpretcx, r=oli-obk

Renames `EvalContext` to `InterpretCx`

This PR renames `EvalContext` to `InterpretCx` in `src/librustc_mir`.
This PR is related to rust-lang#54395 .
@cuviper cuviper mentioned this pull request Mar 28, 2019
Merged
bors added a commit that referenced this pull request Mar 28, 2019
@bors
Auto merge of #59471 - cuviper:rollup, r=cuviper
d20e000 
Rollup of 18 pull requests

Successful merges:

 - #57293 (Make some lints incremental)
 - #57565 (syntax: Remove warning for unnecessary path disambiguators)
 - #58253 (librustc_driver => 2018)
 - #58837 (librustc_interface => 2018)
 - #59268 (Add suggestion to use `&*var` when `&str: From<String>` is expected)
 - #59283 (Make ASCII case conversions more than 4× faster)
 - #59284 (adjust MaybeUninit API to discussions)
 - #59372 (add rustfix-able suggestions to trim_{left,right} deprecations)
 - #59390 (Make `ptr::eq` documentation mention fat-pointer behavior)
 - #59393 (Refactor tuple comparison tests)
 - #59420 ([CI] record docker image info for reuse)
 - #59421 (Reject integer suffix when tuple indexing)
 - #59430 (Renames `EvalContext` to `InterpretCx`)
 - #59439 (Generalize diagnostic for `x = y` where `bool` is the expected type)
 - #59449 (fix: Make incremental artifact deletion more robust)
 - #59451 (Add `Default` to `std::alloc::System`)
 - #59459 (Add some tests)
 - #59460 (Include id in Thread's Debug implementation)

Failed merges:

r? @ghost
@bors bors merged commit 892f7c4 into rust-lang:master Mar 28, 2019
@kenta7777
Copy link
Contributor Author

Thanks！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kenta7777 @rust-highfive @oli-obk @bors @petrochenkov