-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move query definitions over to the proc macro #59517
Conversation
This comment has been minimized.
This comment has been minimized.
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #59561) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors try |
⌛ Trying commit 4558068 with merge 05aa13689919b7b08d5ef1220ae5b31f93835a00... |
Introduce an arena type which may be used to allocate a list of types with destructors You can also specify that you want deserializers for `&'tcx [T]` and `&'tcx T` for a type in the list, which will allocate those using the arena. Based on #59517 and #59533. Look at the last commit for the interesting changes. An alternative to #56448. cc @michaelwoerister @eddyb r? @oli-obk
☀️ Try build successful - checks-travis |
@rust-timer build 05aa13689919b7b08d5ef1220ae5b31f93835a00 |
Success: Queued 05aa13689919b7b08d5ef1220ae5b31f93835a00 with parent befeeb7, comparison URL. |
Finished benchmarking try commit 05aa13689919b7b08d5ef1220ae5b31f93835a00 |
📌 Commit 4558068 has been approved by |
Move query definitions over to the proc macro r? @oli-obk
@bors p=3 Rollup fairness. |
Move query definitions over to the proc macro r? @oli-obk
☀️ Test successful - checks-travis, status-appveyor |
Looks like this broke building |
I see that |
Good question |
The comment says "These are not queries" but it seems to have been turned into a query in the meantime. I don't see a problem with just removing the |
Introduce an arena type which may be used to allocate a list of types with destructors You can also specify that you want deserializers for `&'tcx [T]` and `&'tcx T` for a type in the list, which will allocate those using the arena. Based on #59517 and #59533. Look at the last commit for the interesting changes. An alternative to #56448. cc @michaelwoerister @eddyb r? @oli-obk
There was a big macro rewrite in these pull requests: rust-lang/rust#56462 rust-lang/rust#59517 Update the query chapter to describe the new macro usage.
There was a big macro rewrite in these pull requests: rust-lang/rust#56462 rust-lang/rust#59517 Update the query chapter to describe the new macro usage.
There was a big macro rewrite in these pull requests: rust-lang/rust#56462 rust-lang/rust#59517 Update the query chapter to describe the new macro usage.
r? @oli-obk