-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use arenas to avoid Lrc in queries #1 #59540
Conversation
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Can you say which commits should be reviewed? Thanks. |
@eddyb I'll probably just wait for the based on PRs to get merged (feel free to review those). I want to do some perf runs for these too. |
☔ The latest upstream changes (presumably #59561) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #59632) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors try |
☀️ Try build successful - checks-travis |
@rust-timer build f426a56 |
Success: Queued f426a56 with parent 99da733, comparison URL. |
Finished benchmarking try commit f426a56 |
@bors try |
⌛ Trying commit afcb1b647d249c94aabffdea0fc61364326636be with merge db1920baeb0c1fe34e4fdadb0699d94254383036... |
☀️ Try build successful - checks-travis |
@rust-timer build db1920baeb0c1fe34e4fdadb0699d94254383036 |
Success: Queued db1920baeb0c1fe34e4fdadb0699d94254383036 with parent ee621f4, comparison URL. |
@bors try |
☀️ Try build successful - checks-travis |
@rust-timer build 6da7e37 |
Success: Queued 6da7e37 with parent 112f7e9, comparison URL. |
Finished benchmarking try commit 6da7e37 |
Nice! Feel free to r=me on the current state of the PR. |
@bors r=michaelwoerister |
📌 Commit 53269c7 has been approved by |
☀️ Test successful - checks-travis, status-appveyor |
Use arenas to avoid Lrc in queries rust-lang#2 The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with. Based on rust-lang#59540.
…erister Use arenas to avoid Lrc in queries rust-lang#2 The `Remove subtle Default impl for Value` makes the compilation stop due earlier due to cycle errors, since there's no longer a default value to continue the compilation with. Based on rust-lang#59540.
Based on #59536.