Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for shallow borrows #59585

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Fixes for shallow borrows #59585

merged 1 commit into from
Apr 2, 2019

Conversation

matthewjasper
Copy link
Contributor

  • Don't promote these borrows if we're going to remove them before
    codegen
  • Correctly mark unreachable code

@matthewjasper
Fixes for shallow borrows
16ee042 
* Don't promote these borrows if we're going to remove them before
  codegen
* Correctly mark unreachable code
@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2019
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 1, 2019
@davidtwco
Copy link
Member

These changes look fine to me but I'm not sure of the context, so
r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned davidtwco Apr 2, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Apr 2, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 2, 2019

📌 Commit 16ee042 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2019
@Centril
Rollup merge of rust-lang#59585 - rust-lang:shallow-borrow-fixes, r=p…
69bc687 
…nkfelix

Fixes for shallow borrows

* Don't promote these borrows if we're going to remove them before
  codegen
* Correctly mark unreachable code
@Centril Centril mentioned this pull request Apr 2, 2019
Merged
bors added a commit that referenced this pull request Apr 2, 2019
@bors
Auto merge of #59632 - Centril:rollup, r=Centril
e008e4f 
Rollup of 8 pull requests

Successful merges:

 - #59262 (Remove duplicated code from Iterator::{ne, lt, le, gt, ge})
 - #59286 (Refactor async fn return type lowering)
 - #59444 (Implement useful steps_between for all integers)
 - #59452 (Speed up rustdoc run a bit)
 - #59533 (Support allocating iterators with arenas)
 - #59585 (Fixes for shallow borrows)
 - #59607 (Renames `EvalErrorKind` to `InterpError`)
 - #59613 (SGX target: convert a bunch of panics to aborts)

Failed merges:

 - #59630 (Shrink `mir::Statement`.)

r? @ghost
@bors bors merged commit 16ee042 into master Apr 2, 2019
@matthewjasper matthewjasper deleted the shallow-borrow-fixes branch April 4, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewjasper @rust-highfive @davidtwco @pnkfelix @bors @jonas-schievink