-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HirIdify hir::Def #59877
HirIdify hir::Def #59877
Conversation
3d1c570
to
83600d1
Compare
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This is ready for review now. cc @eddyb |
use rustc::hir::def::*; | ||
use rustc::hir::def::{ | ||
self, PathResolution, CtorKind, CtorOf, NonMacroAttrKind, DefMap, ImportMap, ExportMap | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicit definitions should shadow globs, so leaving the glob would still work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, r=me unless @petrochenkov, or anyone else, has any objections
☔ The latest upstream changes (presumably #59950) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors r=eddyb |
📌 Commit b5d43fc has been approved by |
Rollup of 7 pull requests Successful merges: - #59856 (update polonius-engine) - #59877 (HirIdify hir::Def) - #59896 (Remove duplicated redundant spans) - #59900 (Remove [mut] syntax in pin docs) - #59906 (Make BufWriter use get_mut instead of manipulating inner in Write implementation) - #59936 (Fix cross-crate visibility of fictive variant constructors) - #59957 (Add missing backtick to Symbol documentation.) Failed merges: r? @ghost
Rust upgrade to rustc 1.35.0-nightly (9cd61f0 2019-04-14) Handles breakages from rust-lang/rust#59877 r? @oli-obk @matthiaskrgr
cc @ljedrz
r? @oli-obk