Make deprecation lint ambiguous_associated_items deny-by-default
#59928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-crater
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors retry Let's fix the status for this PR. |
|
⌛ Trying commit bee92b5 with merge ae7846cdce4c82197112f385ba695b23561f1b6c... |
|
☀️ Try build successful - checks-travis |
|
🎉 Experiment
|
craterbot
added
S-waiting-on-review
|
Not much progress has been made (15 regressed before in #57501 (comment)); I'll try to make some time for creating PRs for the crates here. |
Centril
added a commit
to Centril/bluenrg
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/cargo-script
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/jsonrpc
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/pipeliner
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/rust-postgis
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/rcache
that referenced
this pull request
Apr 30, 2019
pka
pushed a commit
to andelf/rust-postgis
that referenced
this pull request
Apr 30, 2019
Centril
added a commit
to Centril/jsonrpc
that referenced
this pull request
Apr 30, 2019
Already migrated
OthersThe remaining regressions have PRs filed. @petrochenkov r=me rollup if you are happy with ^--- |
|
Given that there are only four regressions, each of which has an open PR to fix this issue (and none have reverse dependencies), and that this addresses a future compatibility concern, making this lint deny-by-default seems founded. @bors r+ |
|
📌 Commit bee92b5 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 2, 2019
Make deprecation lint `ambiguous_associated_items` deny-by-default As requested by r? @Centril cc rust-lang#57644
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 2, 2019
Make deprecation lint `ambiguous_associated_items` deny-by-default As requested by r? @Centril cc rust-lang#57644
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 3, 2019
Make deprecation lint `ambiguous_associated_items` deny-by-default As requested by r? @Centril cc rust-lang#57644
bors
added a commit
that referenced
this pull request
May 3, 2019
Rollup of 12 pull requests Successful merges: - #59928 (Make deprecation lint `ambiguous_associated_items` deny-by-default) - #60220 (report fatal errors during doctest parsing) - #60373 (Tidy: ensure lang features are sorted by since) - #60388 (Disallow non-explicit elided lifetimes in async fn) - #60393 ( Do not suggest incorrect syntax on pattern type error due to borrow) - #60401 (Rename `RUST_LOG` to `RUSTC_LOG`) - #60409 (Require a trait in the bounds of existential types) - #60455 (Resolve match arm ty when arms diverge) - #60457 (Const prop refactoring) - #60467 (Avoid repeated interning of static strings.) - #60478 (minor compiler doc tweaks) - #60501 (Propagate mutability from arguments to local bindings in async fn) Failed merges: r? @ghost
3 tasks
daviswahl
added a commit
to daviswahl/rcache
that referenced
this pull request
May 4, 2019
Be forward compatible with rust-lang/rust#59928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by r? @Centril
cc #57644