Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] #59953 without the last commit (i.e. missing an optimization) #60029

Closed
wants to merge 14 commits into from
Closed

[WIP] #59953 without the last commit (i.e. missing an optimization) #60029

wants to merge 14 commits into from

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Apr 17, 2019

This will never be merged, only needed for a try build, see #59953 (comment) for explanation

eddyb added 14 commits April 16, 2019 15:09
@eddyb
rustc_metadata: more safely read/write the index positions.
f51e6c7
@eddyb
rustc_metadata: parametrize schema::CrateRoot by 'tcx.
35d2f64
@eddyb
rustc_metadata: rip out unused incremental infrastructure.
6ae65dd
@eddyb
rustc_metadata: replace LazySeq<T> with Lazy<[T]>.
66c8763
@eddyb
rustc_metadata: use NonZeroUsize for the position of a Lazy.
78fa21d
@eddyb
rustc_metadata: use 0 in index::Index to indicate missing entries.
51c5e5f
@eddyb
rustc_metadata: rename index::Index to table::Table.
98e04ba
@eddyb
rustc_metadata: parametrize Table by element type.
2212aa4
@eddyb
rustc_metadata: replace Lazy<[Table<T>]> with Lazy<Table<T>>.
538f882
@eddyb
rustc_metadata: split tables into an usize-keyed Table and a DefIndex…
47dfc2f 
…-keyed PerDefTable.
@eddyb
rustc_metadata: add a helper macro for recording into PerDefTable's.
010958c
@eddyb
rustc_metadata: generalize Table<T> to hold T, not Lazy<T>, elements.
050276a
@eddyb
rustc_metadata: use decoder::Metadata instead of &[u8] for Lazy<Table…
96b6b19 
…<T>>::get.
@eddyb
rustc_metadata: replace Entry table with one table for each of its fi…
12f0c3a 
…elds (AoS -> SoA).
@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2019
@eddyb
Copy link
Member Author

eddyb commented Apr 17, 2019

@bors try

@bors
Copy link
Contributor

bors commented Apr 17, 2019

⌛ Trying commit 12f0c3a with merge 399b539e96cc10d091b702eb10ad7bd2dd81634c...

@eddyb eddyb mentioned this pull request Apr 17, 2019
Merged
@bors
Copy link
Contributor

bors commented Apr 17, 2019

☀️ Try build successful - checks-travis
Build commit: 399b539e96cc10d091b702eb10ad7bd2dd81634c

@pnkfelix
Copy link
Member

as far as I can tell, this was only a temporary PR for an isolated try build on #59953, but it is never going to be merged as is, and does not even need to be reviewed.

Closing.

@pnkfelix pnkfelix closed this May 13, 2019
@eddyb eddyb deleted the soa-metadata-minus-last-commit branch May 13, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eddyb @rust-highfive @bors @pnkfelix