Continue evaluating after item-type checking #60126
Conversation
rust-highfive
added
the
S-waiting-on-review
| | ^^^^^^^^^^ | ||
| | | ||
| = note: ...which again requires processing `MList`, completing the cycle | ||
| = note: cycle used when computing dropck types for `Canonical { max_universe: U0, variables: [], value: ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: UserFacing, def_id: None }, value: MList } }` |
There was a problem hiding this comment.
This note doesn't seem like something the user would understand... :)
There was a problem hiding this comment.
It doesn't. There hard error removal is causing some spurious and duplicated errors that I want to hide, but for now I want to put these changes out asap so that's we can capture any lurking ICEs.
There was a problem hiding this comment.
we have a lot of cycle errors without comprehensible diagnostics. This is something that needs to be addressed in general and is not specific to this PR
| | ^^^^^^^^^^ | ||
| | | ||
| = note: ...which again requires processing `MList`, completing the cycle | ||
| = note: cycle used when computing dropck types for `Canonical { max_universe: U0, variables: [], value: ParamEnvAnd { param_env: ParamEnv { caller_bounds: [], reveal: UserFacing, def_id: None }, value: MList } }` |
There was a problem hiding this comment.
we have a lot of cycle errors without comprehensible diagnostics. This is something that needs to be addressed in general and is not specific to this PR
src/test/ui/rfc-1937-termination-trait/termination-trait-test-wrong-type.rs
Outdated
Show resolved
Hide resolved
|
Just some nits. This is definitely a great improvement, the two problems discovered are preexisting and should be addressed independently. Please open issues about them. r=me with the above |
|
@bors r=oli-obk |
|
📌 Commit 2dc5d52 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-travis, status-appveyor |
Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past type checking after encountering errors.
`delay_span_bug` when codegen cannot select obligation Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past type checking after encountering errors.
`delay_span_bug` when codegen cannot select obligation Fix rust-lang#69602, introduced in rust-lang#60126 by letting the compiler continue past type checking after encountering errors.
Fix #30999.
r? @oli-obk