Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize Option::xor #60376

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Stabilize Option::xor #60376

merged 1 commit into from
Jun 13, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented Apr 29, 2019 •
edited
Loading

FCP done in #50512 (comment) .

Closes #50512 .

@rust-highfive
Copy link
Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 29, 2019
@tesuji

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Apr 29, 2019

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 29, 2019
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 29, 2019
@jonas-schievink jonas-schievink added this to the 1.36 milestone Apr 29, 2019
@tesuji
Copy link
Contributor Author

tesuji commented Apr 29, 2019

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

FCP completed but @Amanieu and @withoutboats expressed doubts so I'm going to r? @Amanieu for final approval.

@tesuji
Copy link
Contributor Author

tesuji commented May 9, 2019 •
edited
Loading

Are there any updates from libs team?

@tesuji
Copy link
Contributor Author

tesuji commented May 15, 2019

Hi, is there any update yet?

@Centril
Copy link
Contributor

Centril commented May 18, 2019

Would love to see this stabilized. I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase. I've hit that before when working on proc macro implementations.

@taiki-e
Copy link
Member

taiki-e commented May 18, 2019

@Centril

I do think it brings clarity and ergonomics to the "I have several incompatible options, select one of them but only if that's the only one given"-usecase.

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@Centril
Copy link
Contributor

Centril commented May 18, 2019

If I understand correctly, Option::xor can only be used if there are two options in this use-case.

@taiki-e Yeah that's true; In my cases I only had two options.

@tesuji tesuji force-pushed the stabilize-option_xor branch from c72a5d4 to da56758 Compare May 27, 2019 09:08
@tesuji
Copy link
Contributor Author

tesuji commented May 27, 2019

@Amanieu Does the lib team have any updates?

@Centril Centril modified the milestones: 1.36, 1.37 May 27, 2019
@tesuji tesuji force-pushed the stabilize-option_xor branch from da56758 to 1fa50b3 Compare June 5, 2019 02:17
@tesuji
Copy link
Contributor Author

tesuji commented Jun 12, 2019

Spamming ping @Amanieu .

@SimonSapin
Copy link
Contributor

Per FCP:

@bors r+

@bors
Copy link
Contributor

bors commented Jun 12, 2019

📌 Commit 1fa50b3 has been approved by SimonSapin

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 12, 2019
@Centril
Copy link
Contributor

Centril commented Jun 12, 2019

@bors rollup

Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
@Centril
Rollup merge of rust-lang#60376 - lzutao:stabilize-option_xor, r=Simo…
20858c4 
…nSapin

Stabilize Option::xor

FCP done in rust-lang#50512 (comment) .

Closes rust-lang#50512 .
@Centril Centril mentioned this pull request Jun 12, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jun 12, 2019
@Centril
Rollup merge of rust-lang#60376 - lzutao:stabilize-option_xor, r=Simo…
b35aeae 
…nSapin

Stabilize Option::xor

FCP done in rust-lang#50512 (comment) .

Closes rust-lang#50512 .
@Centril Centril mentioned this pull request Jun 12, 2019
Merged
bors added a commit that referenced this pull request Jun 13, 2019
@bors
Auto merge of #61789 - Centril:rollup-hhyvopq, r=Centril
d8f50ab 
Rollup of 9 pull requests

Successful merges:

 - #60376 (Stabilize Option::xor)
 - #61398 (Stabilize copy_within)
 - #61629 (Hygienize macros in the standard library)
 - #61675 (Include frame pointer for bare metal RISC-V targets)
 - #61750 (Fix x.py install)
 - #61761 (Add an alias for x86_64-sun-solaris target tuple)
 - #61762 (rustbuild: fix libtest_stamp)
 - #61763 (ci: fix ci stats upload condition)
 - #61776 (Fix typos in error_codes)

Failed merges:

r? @ghost
@bors bors merged commit 1fa50b3 into rust-lang:master Jun 13, 2019
@tesuji tesuji deleted the stabilize-option_xor branch June 13, 2019 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.

Tracking issue for Option::xor