-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tests compatible with musl host #60474
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This seems alright to me, but tbh it feels pretty random and it's just sort of sprinkling a few |
The problem is that many parts of the tests work by calling different executables and |
Yeah I understand that the defaults are throwing things off, but compiletest is already a giant ball of |
That's why it's in
Anyway I don't mind whatever happens to this PR, I linked it in #59302 so it shouldn't be hard to find if somebody (distro maintainers?) want to use it. It shouldn't bitrot much. |
Do you want to land this? This is r=me as it looks like it's passing and it's a small enough footprint it seems reasonable to land. |
Removed temporary commit, squased and ran rustfmt over my changes (it changed only https://github.com/rust-lang/rust/pull/60474/files#diff-442d7ffcafff5c5246d8c6c287fd5683R1640). This should be ready to go. |
@bors: r+ |
📌 Commit 98b7abb31de60eabacf6384969d79185c0a5dd15 has been approved by |
⌛ Testing commit 98b7abb31de60eabacf6384969d79185c0a5dd15 with merge c17c7fce2397b0ddbd489d6063eb4edd259db80a... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Any opinions? |
I don't personally have a preference of how this would be solved. |
Rebased and added fix in a new commit (to ease reviewing, I can squash it afterwards). |
@bors: r+ |
@bors: retry network issues |
⌛ Testing commit 0caa251 with merge 726c22d523fdf2c2947dd3468d38a0cd88f63017... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
#58209 |
@bors retry |
@bors rollup=never |
⌛ Testing commit 0caa251 with merge 522af3dac5b6c31170239df06dbaad65b14badb8... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Network error once more:
|
@bors retry |
Make tests compatible with musl host As an alternative to passing explicit linker all over the place I could try linking `cc` to musl gcc since this bootstraps itself. Assigning for discussion: r? @alexcrichton
☀️ Test successful - checks-travis, status-appveyor |
As an alternative to passing explicit linker all over the place I could try linking
cc
to musl gcc since this bootstraps itself.Assigning for discussion:
r? @alexcrichton