Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cargo #60874

Merged
merged 1 commit into from
May 16, 2019
Merged

Update cargo #60874

merged 1 commit into from
May 16, 2019

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented May 16, 2019

17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280
2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 16, 2019
@ehuss
Copy link
Contributor Author

ehuss commented May 16, 2019

r? @alexcrichton

This includes an override to allow this PR to pass since it breaks rls. rls cannot be updated due to #60848. The Cargo team would like to land these changes before the beta branch, and it seems unlikely that the clippy/rls issue will be fixed in time.

I have the fixes for rls waiting in the wings (ehuss/rls@f2d51d0), and I'm willing to help fix rls once the clippy issue is resolved.

@Mark-Simulacrum
Copy link
Member

cc @Manishearth @Xanewok @nrc re:clippy/rls breakage

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 16, 2019

📌 Commit 2811d3220b5120fb8432ea623bb01a89d39c1b91 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2019
@alexcrichton
Copy link
Member

@bors: p=1 delegate+

@bors
Copy link
Contributor

bors commented May 16, 2019

✌️ @ehuss can now approve this pull request

@Eh2406
Copy link
Contributor

Eh2406 commented May 16, 2019

One piece of context for those just joining this conversation:
One of the changes included in this (rust-lang/cargo#6940) is a fix for a bug that broke Crater. So this is a High priority, if we want to do the normal Crater runs on Beta.

@Centril
Copy link
Contributor

Centril commented May 16, 2019

@bors p=2

@bors
Copy link
Contributor

bors commented May 16, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout update-cargo (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self update-cargo --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2019
@ehuss
Copy link
Contributor Author

ehuss commented May 16, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented May 16, 2019

📌 Commit 6a09cfa has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2019
@bors
Copy link
Contributor

bors commented May 16, 2019

⌛ Testing commit 6a09cfa with merge 7d5aa43...

bors added a commit that referenced this pull request May 16, 2019
Update cargo

17 commits in 759b6161a328db1d4863139e90875308ecd25a75..c4fcfb725b4be00c72eb9cf30c7d8b095577c280
2019-05-06 20:47:49 +0000 to 2019-05-15 19:48:47 +0000
- tests: registry: revert readonly permission after running tests. (rust-lang/cargo#6947)
- Remove Candidate (rust-lang/cargo#6946)
- Fix for "Running cargo update without a Cargo.lock ignores arguments" rust-lang/cargo#6872 (rust-lang/cargo#6904)
- Fix a minor mistake in the changelog. (rust-lang/cargo#6944)
- Give a better error message when crates.io requests time out (rust-lang/cargo#6936)
- Re-enable compatibility with readonly CARGO_HOME (rust-lang/cargo#6940)
- Fix version of `ignore`. (rust-lang/cargo#6938)
- Stabilize offline mode. (rust-lang/cargo#6934)
- zsh: Add doc options to include non-public items documentation (rust-lang/cargo#6929)
- zsh: Suggest --lib option as binary template now the default (rust-lang/cargo#6926)
- Migrate package include/exclude to gitignore patterns. (rust-lang/cargo#6924)
- Implement the Cargo half of pipelined compilation (take 2) (rust-lang/cargo#6883)
- Always include `Cargo.toml` when packaging. (rust-lang/cargo#6925)
- Remove unnecessary calls to masquerade_as_nightly_cargo. (rust-lang/cargo#6923)
- download: fix "Downloaded 1 crates" message (crates -> crate) (rust-lang/cargo#6920)
- Changed RUST_LOG usage to CARGO_LOG to avoid confusion. (rust-lang/cargo#6918)
- crate download: don't print that a crate was the largest download if it was the only download (rust-lang/cargo#6916)
@bors bors mentioned this pull request May 16, 2019
@bors
Copy link
Contributor

bors commented May 16, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing 7d5aa43 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 16, 2019
@bors bors merged commit 6a09cfa into rust-lang:master May 16, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #60874!

Tested on commit 7d5aa43.
Direct link to PR: #60874

💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 16, 2019
Tested on commit rust-lang/rust@7d5aa43.
Direct link to PR: <rust-lang/rust#60874>

💔 rls on windows: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
💔 rls on linux: test-fail → build-fail (cc @Xanewok, @rust-lang/infra).
@Xanewok Xanewok mentioned this pull request May 18, 2019
bors added a commit that referenced this pull request May 19, 2019
Update RLS

Includes a fix (rust-lang/rls#1462) for breakage due to Cargo update PR (#60874)

r? @Manishearth @oli-obk @ehuss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants