Add entry-like methods to HashSet #60894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `HashSet::get_or_insert` * `HashSet::get_or_insert_with` These provide a simplification of the `Entry` API for `HashSet`, with names chosen to match the similar methods on `Option`.
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 5f93834 has been approved by |
bors
added
S-waiting-on-bors
|
Can you also open a tracking issue for these? |
4 tasks
|
📌 Commit 5e2c9d3 has been approved by |
Centril
reviewed
May 16, 2019
|
@bors r=cramertj,Centril |
|
📌 Commit 9161a4d has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 17, 2019
…Centril Add entry-like methods to HashSet * `HashSet::get_or_insert` * `HashSet::get_or_insert_with` These provide a simplification of the `Entry` API for `HashSet`, with names chosen to match the similar methods on `Option`.
bors
added a commit
that referenced
this pull request
May 17, 2019
Rollup of 6 pull requests Successful merges: - #60685 (Switch to SPDX 2.1 license expression) - #60687 (Fix .natvis visualizers.) - #60805 (remove compiletest's dependency on `filetime`) - #60862 (Get ty from local_decls instead of using Place) - #60873 (Parse alternative incorrect uses of await and recover) - #60894 (Add entry-like methods to HashSet) Failed merges: r? @ghost
Amanieu
added a commit
to Amanieu/hashbrown
that referenced
this pull request
Jul 4, 2019
This is ported from rust-lang/rust#60894
Amanieu
added a commit
to Amanieu/hashbrown
that referenced
this pull request
Jul 4, 2019
This is ported from rust-lang/rust#60894
bors
added a commit
to rust-lang/hashbrown
that referenced
this pull request
Jul 4, 2019
Add entry-like methods to HashSet This is ported from rust-lang/rust#60894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashSet::get_or_insertHashSet::get_or_insert_withThese provide a simplification of the
EntryAPI forHashSet, withnames chosen to match the similar methods on
Option.