-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] NLL crater run 2: deny NLL warning lints in migrate mode #60914
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors try |
⌛ Trying commit f2d2a4a with merge f45cc3094ee337acd688771b9234318046b0572d... |
☀️ Try build successful - checks-travis |
@craterbot run start=master#39401465da4ce27aeeb2c2a26133ac35c63aa515 end=try#f45cc3094ee337acd688771b9234318046b0572d mode=check-only |
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🚧 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
🎉 Experiment
|
Not unexpected results: these 87 crates caused 1859 crates to fail downstream, while these 54 crates failed to build themselves. There is some overlap between these 2 categories: so this PR impacted around 130 root crates. I remember a lot of those from the previous crater runs, with legit errors — some of them fixed in more recent versions of the crates (including semver-compatible releases only requiring a |
The lang team should have the data they need for this run, so closing the PR. |
for my own future reference: today I attempted the exercise of actually categorizing each of the bugs that @lqd identified above. I've been logging the results of that investigation at this very sketchy spreadsheet: https://docs.google.com/spreadsheets/d/1is65VZSGNNhQSNXiyWVWR0OwkTbnwp-r3LH4195MZms/edit?usp=sharing |
[DO NOT MERGE] NLL crater run 3: deny NLL warnings in migrate mode Forward port of #60914. r? @ghost cc @rust-lang/lang cc @rust-lang/wg-compiler-nll
This keeps the borrowck migrate mode as the default (and thus does not suppress regionck errors like full NLLs would), but does not downgrade the errors ignored by AST borrowck into warnings, for the 2nd crater run needed for #60680.
For the previous runs, we also specified crater to cap-lints=warn, we might want this again this time ?
r? @ghost
cc @pnkfelix, @Centril, @matthewjasper