Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an ICE encountered in clippy that will be possible to trigger in rustc in the future #61041

Closed
wants to merge 23 commits into from
Closed

Fix an ICE encountered in clippy that will be possible to trigger in rustc in the future #61041

wants to merge 23 commits into from

Commits on Aug 12, 2019

  1. Fix an ICE encountered in clippy integration tests

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    16911bd View commit details
    Browse the repository at this point in the history

  2. A comment mentioned the wrong function

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    d38fb10 View commit details
    Browse the repository at this point in the history

  3. Typo

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b535090 View commit details
    Browse the repository at this point in the history

  4. Document all the things

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    e849b83 View commit details
    Browse the repository at this point in the history

  5. WIP: Unbrittle the miri engine around unsubstituted values

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    600d679 View commit details
    Browse the repository at this point in the history

  6. Privatize subst_and_normalize_erasing_regions

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    27320e3 View commit details
    Browse the repository at this point in the history

  7. Clarify doc comments some more

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b84ed30 View commit details
    Browse the repository at this point in the history

  8. Simplify subst_and_normalize_erasing_regions

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    7fac3a1 View commit details
    Browse the repository at this point in the history

  9. Fix incremental test

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    8ac4cb5 View commit details
    Browse the repository at this point in the history

  10. Substitute const generics so we can evaluate them

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    fe2013c View commit details
    Browse the repository at this point in the history

  11. Explain partial substitution

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    1d26fda View commit details
    Browse the repository at this point in the history

  12. Abort evaluation when substuting a value still requires more substitu… 

    …tion.

This is probably overly restrictive, but the safe choice for now.

e.g. we can't evaluate `fn foo<T>() -> i32 { 42 }` inside an associated constant of a generic trait, even though that should be doable
    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    b917c43 View commit details
    Browse the repository at this point in the history

  13. Substituting with identity substs is equivalent to not substituting a… 

    …t all
    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    5a8c9d3 View commit details
    Browse the repository at this point in the history

  14. Reintroduce sanity assert

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    faa342f View commit details
    Browse the repository at this point in the history

  15. Remove now-useless impl

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    51e1343 View commit details
    Browse the repository at this point in the history

  16. Unbreak a line

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    034939b View commit details
    Browse the repository at this point in the history

  17. Unbreak more lines

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    685e0e5 View commit details
    Browse the repository at this point in the history

  18. Address review comments and unbreak more lines

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    fdf5450 View commit details
    Browse the repository at this point in the history

  19. Adjust incremental test

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    3afcb1e View commit details
    Browse the repository at this point in the history

  20. Address review comments

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    f0a16c4 View commit details
    Browse the repository at this point in the history

  21. We don't have polymorphic things without a stackframe anymore

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    3aa550a View commit details
    Browse the repository at this point in the history

  22. Only monomorphize things from the current frame's MIR, not arbitrary … 

    …polymorphic things
    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    82db274 View commit details
    Browse the repository at this point in the history

  23. Work around a MIR bug

    @oli-obk
    oli-obk committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    70124ec View commit details
    Browse the repository at this point in the history