Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable target thumbv7a-pc-windows-msvc in nightly build #61050

Closed
wants to merge 1 commit into from
Closed

enable target thumbv7a-pc-windows-msvc in nightly build #61050

wants to merge 1 commit into from

Conversation

chandde
Copy link
Contributor

@chandde chandde commented May 22, 2019

This change (hopefully) enables the target thumbv7a-pc-windows-msvc in nightly build, this is a follow up of this PR #60895 which enables the build end to end, now it's time to enable this target in nightly build, so user can simply rustup to get this target and build their thumbv7a project for Windows.

How can I verify this change? I'm not very certain if I made enough changes here, I need some information regarding when and where the build happens in master, so I can check out the pipeline. Or do I have to wait a couple days, and try add new target from nightly build, if I can successfully install the new target, it mean it worked?

Follow up question
I also noticed aarch64-pc-windows-msvc are mentioned in another two repos, https://github.com/rust-lang/libc.git (https://github.com/chandde/libc/commit/fe67c762ac26292a6914432290bd1d8b1627ac49) and https://github.com/rust-lang/rust-forge.git (https://github.com/chandde/rust-forge/commit/5faa6d5ccd5ada866017638259f870324d90b8c2). I believe I'll need to add thumbv7a there as well, but only after this PR is merged and it's being built successfully in nightly build?

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2019
@alexcrichton
Copy link
Member

Thanks for the PR! Unfortunately though I'm not sure that we can do this at this time. All our builders look to basically be "full up" in the sense that they're all easily blowing the 2h soft time limit we set for ourselves, almost all entering the 2h20m territory.

We can try to revisit this when we have more CI budget capacity, but for now I don't think we're able to hook up a builder for this :(

@chandde
Copy link
Contributor Author

chandde commented May 24, 2019

@alexcrichton thanks for responding and explaining. While it's not easy to put it in nightly build, is there less frequent build like weekly, or on demand? I'd really like people to install the target when they need to compile thumbv7a on windows, instead of pulling the entire rust master and build the compiler on their own.

Or like Azure devops, is there a way to host a (private) build agent locally and add to the pool, and the agent can be dedicated to build thumv7a only?

@alexcrichton
Copy link
Member

Unfortunately we don't have a good place to slot this in right now (nothing like a slower weekly build or something like that). We're hoping to in the somewhat near future get more build capacity, but that's not certain or locked down yet. If that comes through we can hopefully unblock this!

@chandde
Copy link
Contributor Author

chandde commented May 28, 2019

thank you, should I close the pr for now or keep it open as a reminder?

I wonder if there is a pending list that I can add this triple..?

@alexcrichton

@alexcrichton
Copy link
Member

Ah sorry we're not currently maintaining this list anywhere right now, so it's probably best to close in the meantime. I'll try to be sure to let you know though if we have more capacity open up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants