enable target thumbv7a-pc-windows-msvc in nightly build #61050
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (hopefully) enables the target
thumbv7a-pc-windows-msvc
in nightly build, this is a follow up of this PR #60895 which enables the build end to end, now it's time to enable this target in nightly build, so user can simply rustup to get this target and build their thumbv7a project for Windows.How can I verify this change? I'm not very certain if I made enough changes here, I need some information regarding when and where the build happens in master, so I can check out the pipeline. Or do I have to wait a couple days, and try add new target from nightly build, if I can successfully install the new target, it mean it worked?
Follow up question
I also noticed aarch64-pc-windows-msvc are mentioned in another two repos, https://github.com/rust-lang/libc.git (https://github.com/chandde/libc/commit/fe67c762ac26292a6914432290bd1d8b1627ac49) and https://github.com/rust-lang/rust-forge.git (https://github.com/chandde/rust-forge/commit/5faa6d5ccd5ada866017638259f870324d90b8c2). I believe I'll need to add thumbv7a there as well, but only after this PR is merged and it's being built successfully in nightly build?