Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit save analysis notifications #61052

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

jsgf
Copy link
Contributor

@jsgf jsgf commented May 22, 2019

Addresses issue #61047

@jsgf
Copy link
Contributor Author

jsgf commented May 22, 2019

r? @alexcrichton

@rust-highfive

This comment has been minimized.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2019
@rust-highfive rust-highfive assigned alexcrichton and unassigned varkor May 22, 2019
@jsgf jsgf force-pushed the emit-save-analysis-notifications branch from d7029bb to 820717e Compare May 22, 2019 19:35
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 23, 2019

📌 Commit 820717e7c76507bb94ec6ee90675f1b1cdb5cdd3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2019
@jsgf jsgf force-pushed the emit-save-analysis-notifications branch from 820717e to 1d5fc11 Compare May 23, 2019 22:15
@jsgf
Copy link
Contributor Author

jsgf commented Jun 3, 2019

Is this stuck?

@alexcrichton
Copy link
Member

@bors: r+

Looks like bors forgot about it by accident!

@bors
Copy link
Contributor

bors commented Jun 3, 2019

📌 Commit 1d5fc110554b8f065496977ddc4d93c6cd957179 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jun 3, 2019

⌛ Testing commit 1d5fc110554b8f065496977ddc4d93c6cd957179 with merge 62a33aa6ec6c9b037241f6e6f63c6db39a3d8fac...

@bors
Copy link
Contributor

bors commented Jun 3, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job test-various of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:11:35] 
[01:11:35] ---- [ui] ui/save-analysis/emit-notifications.rs stdout ----
[01:11:35] diff of stderr:
[01:11:35] 
[01:11:35] 1 {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications/save-analysis/emit_notifications.json","emit":"save-analysis"}
[01:11:35] - {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications/emit-notifications","emit":"link"}
[01:11:35] + {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications/emit-notifications.wasm","emit":"link"}
[01:11:35] 
[01:11:35] 
[01:11:35] The actual stderr differed from the expected stderr.
[01:11:35] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications/emit-notifications.stderr
[01:11:35] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications/emit-notifications.stderr
[01:11:35] To update references, rerun the tests and pass the `--bless` flag
[01:11:35] To only update this specific test, also pass `--test-args save-analysis/emit-notifications.rs`
[01:11:35] error: 1 errors occurred comparing output.
[01:11:35] status: exit code: 0
[01:11:35] status: exit code: 0
[01:11:35] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/save-analysis/emit-notifications.rs" "-Zthreads=1" "--target=wasm32-unknown-unknown" "-Zui-testing" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "-Zsave-analysis" "-Zemit-artifact-notifications" "--error-format=json" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications/auxiliary" "-A" "unused"
[01:11:35] ------------------------------------------
[01:11:35] 
[01:11:35] ------------------------------------------
[01:11:35] stderr:
---
[01:11:35] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:11:35] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:11:35] 
[01:11:35] 
[01:11:35] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-unknown/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-wasm32-unknown-unknown" "--mode" "ui" "--target" "wasm32-unknown-unknown" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/node-v9.2.0-linux-x64/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-unknown/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0-rust-1.37.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:11:35] 
[01:11:35] 
[01:11:35] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-unknown src/test/run-make src/test/ui src/test/run-pass src/test/compile-fail src/test/mir-opt src/test/codegen-units src/libcore
[01:11:35] Build completed unsuccessfully in 1:02:52
---
travis_time:end:01e37981:start=1559589102827201834,finish=1559589102838585291,duration=11383457
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:057de91b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0f9f0d50
travis_time:start:0f9f0d50
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:01a2d7ee
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 3, 2019
@jsgf jsgf force-pushed the emit-save-analysis-notifications branch from 1d5fc11 to 5785060 Compare June 4, 2019 16:43
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:046316c4:start=1559666700542577845,finish=1559666701820243429,duration=1277665584
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:05:05] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:05] tidy error: /checkout/src/test/ui/save-analysis/emit-notifications.rs:2: line longer than 100 chars
[00:05:10] some tidy checks failed
[00:05:10] 
[00:05:10] 
[00:05:10] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:10] 
[00:05:10] 
[00:05:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:10] Build completed unsuccessfully in 0:01:13
---
travis_time:end:00bb53b4:start=1559667024300791402,finish=1559667024305948395,duration=5156993
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:09696d50
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:076a9142
travis_time:start:076a9142
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:06f1db20
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jsgf jsgf force-pushed the emit-save-analysis-notifications branch from 5785060 to beacc33 Compare June 4, 2019 17:32
@jsgf
Copy link
Contributor Author

jsgf commented Jun 4, 2019

Tests fixed.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 4, 2019

📌 Commit beacc33c3816f0b7205c6d74dd506d3fde480fde has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2019
@bors
Copy link
Contributor

bors commented Jun 5, 2019

⌛ Testing commit beacc33c3816f0b7205c6d74dd506d3fde480fde with merge fccda5675755bf60eed916c820a3ba06a8e84120...

@bors
Copy link
Contributor

bors commented Jun 5, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-nopt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:20:26] 
[01:20:26] ---- [ui (nll)] ui/save-analysis/emit-notifications.rs stdout ----
[01:20:26] diff of stderr:
[01:20:26] 
[01:20:26] - {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications/save-analysis/libemit_notifications.json","emit":"save-analysis"}
[01:20:26] - {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications/libemit_notifications.rlib","emit":"link"}
[01:20:26] + {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications.nll/save-analysis/libemit_notifications.json","emit":"save-analysis"}
[01:20:26] + {"artifact":"$TEST_BUILD_DIR/save-analysis/emit-notifications.nll/libemit_notifications.rlib","emit":"link"}
[01:20:26] 
[01:20:26] 
[01:20:26] The actual stderr differed from the expected stderr.
[01:20:26] The actual stderr differed from the expected stderr.
[01:20:26] Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications.nll/emit-notifications.nll.stderr
[01:20:26] To update references, rerun the tests and pass the `--bless` flag
[01:20:26] To only update this specific test, also pass `--test-args save-analysis/emit-notifications.rs`
[01:20:26] error: 1 errors occurred comparing output.
[01:20:26] status: exit code: 0
[01:20:26] status: exit code: 0
[01:20:26] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/save-analysis/emit-notifications.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications.nll" "-Zborrowck=mir" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Zsave-analysis" "-Zemit-artifact-notifications" "--crate-type" "rlib" "--error-format=json" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/save-analysis/emit-notifications.nll/auxiliary" "-A" "unused"
[01:20:26] ------------------------------------------
[01:20:26] 
[01:20:26] ------------------------------------------
[01:20:26] stderr:
---
[01:20:26] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:521:22
[01:20:26] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:20:26] 
[01:20:26] 
[01:20:26] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "8.0.0-rust-1.37.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always" "--compare-mode" "nll"
[01:20:26] 
[01:20:26] 
[01:20:26] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:20:26] Build completed unsuccessfully in 1:17:13
---
travis_time:end:0ca06ce6:start=1559722716237748666,finish=1559722716244085446,duration=6336780
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:023b01fd
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1bca75a4
travis_time:start:1bca75a4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:399fa02a
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2019
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@Centril
Copy link
Contributor

Centril commented Jun 10, 2019

Ping from triage; @jsgf looks like you need to --bless --compare-mode=nll ?

@jsgf
Copy link
Contributor Author

jsgf commented Jun 10, 2019

@Centril Thanks - I wasn't sure how to deal with that.

@jsgf jsgf force-pushed the emit-save-analysis-notifications branch from beacc33 to 7a22c34 Compare June 10, 2019 16:44
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 10, 2019

📌 Commit 7a22c34 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 10, 2019
@jsgf
Copy link
Contributor Author

jsgf commented Jun 10, 2019

Whee! All passed.

@bors
Copy link
Contributor

bors commented Jun 11, 2019

⌛ Testing commit 7a22c34 with merge efc30d0...

bors added a commit that referenced this pull request Jun 11, 2019
…richton

Emit save analysis notifications

Addresses issue #61047
@bors
Copy link
Contributor

bors commented Jun 11, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing efc30d0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 11, 2019
@bors bors merged commit 7a22c34 into rust-lang:master Jun 11, 2019
@jsgf jsgf deleted the emit-save-analysis-notifications branch June 11, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants