Added error message for E0284 #61220
Conversation
|
Some changes occurred in diagnostic error codes |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
Looks good to me. Could an english native double-check if that I didn't miss something please? cc @rust-lang/docs |
This comment has been minimized.
This comment has been minimized.
|
I incorporated the suggested changes on my local fork and pushed up. Did I do it right? |
imbrem
force-pushed
the
error_explanations
branch
2 times, most recently
from
1ada835 to
523cf5b
Compare
This comment has been minimized.
This comment has been minimized.
|
You'll need to run |
imbrem
force-pushed
the
error_explanations
branch
from
523cf5b to
da34fd3
Compare
|
@estebank did I do it right? |
|
r? @estebank |
imbrem
force-pushed
the
error_explanations
branch
from
da34fd3 to
b348012
Compare
|
@bors r+ rollup |
|
📌 Commit b348012 has been approved by |
bors
added
S-waiting-on-bors
Added error message for E0284 Work on rust-lang#61137
Rollup of 9 pull requests Successful merges: - #61084 (Clarify docs for unreachable! macro) - #61220 (Added error message for E0284) - #61227 (Use .await syntax instead of await!) - #61230 (avoid creating Boxes of uninitalized values in RawVec) - #61237 (Updated the Iterator docs with information about overriding methods.) - #61241 (Check place iterative) - #61242 (Make dest_needs_borrow iterate instead of recurse) - #61247 (Make eval_place iterate instead of recurse) - #61248 (Use Place::local) Failed merges: r? @ghost
Rollup of 9 pull requests Successful merges: - #61084 (Clarify docs for unreachable! macro) - #61220 (Added error message for E0284) - #61227 (Use .await syntax instead of await!) - #61230 (avoid creating Boxes of uninitalized values in RawVec) - #61237 (Updated the Iterator docs with information about overriding methods.) - #61241 (Check place iterative) - #61242 (Make dest_needs_borrow iterate instead of recurse) - #61247 (Make eval_place iterate instead of recurse) - #61248 (Use Place::local) Failed merges: r? @ghost
Work on #61137