Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize bufreader_buffer feature #61235

Merged
merged 1 commit into from
May 29, 2019

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 27, 2019

FCP done in #45323 (comment)

Closes #45323

r? @SimonSapin

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2019
@tesuji

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented May 27, 2019

Error: Label relnotes can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 27, 2019
@Centril Centril added the relnotes Marks issues that should be documented in the release notes of the next release. label May 27, 2019
@Centril Centril added this to the 1.37 milestone May 27, 2019
@Centril
Copy link
Contributor

Centril commented May 29, 2019

r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2019

📌 Commit 06eb412 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned SimonSapin May 29, 2019
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2019
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
bors added a commit that referenced this pull request May 29, 2019
Rollup of 11 pull requests

Successful merges:

 - #58975 (Implement `iter::Sum` and `iter::Product` for `Option`)
 - #60542 (Add Step::sub_usize)
 - #60555 (Implement nth_back for RChunks(Exact)(Mut))
 - #60766 (Weak::into_raw)
 - #61048 (Feature/nth back chunks)
 - #61191 (librustc_errors: Move annotation collection to own impl)
 - #61235 (Stabilize bufreader_buffer feature)
 - #61249 (Rename Place::local to Place::local_or_deref_local)
 - #61291 (Avoid unneeded bug!() call)
 - #61294 (Rename `TraitOrImpl` to `Assoc` and `trait_or_impl` to `assoc`.)
 - #61297 (Remove LLVM instruction stats and other (obsolete) codegen stats.)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request May 29, 2019
@bors bors merged commit 06eb412 into rust-lang:master May 29, 2019
@tesuji tesuji deleted the stabilize-bufreader_buffer branch May 29, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BufReader/Writer extension methods: is_empty, buffer
6 participants