Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::time fix typo on now() comments #61433

Closed
wants to merge 1 commit into from
Closed

std::time fix typo on now() comments #61433

wants to merge 1 commit into from

Conversation

bekicot
Copy link

@bekicot bekicot commented Jun 1, 2019

Fix typo, update words, and remove some redundant word.

@bekicot
std::time fix typo on now() comments
cc467cd 
Fix typo, update words, and remove some redundant word.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 1, 2019
czipperz
czipperz reviewed Jun 1, 2019
View reviewed changes
src/libstd/time.rs
@@ -170,14 +170,14 @@ impl Instant {
// * https://bugzilla.mozilla.org/show_bug.cgi?id=1487778 - a similar
// Firefox bug
//
// It simply seems that this it just happens so that a lot in the wild
// we're seeing panics across various platforms where consecutive calls
// It seems that this is just happens a lot in the wild.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This grammar is still messed up. Try removing the word is.

@tesuji

This comment has been minimized.

Sign in to view
@rustbot rustbot added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jun 1, 2019
@kennytm
Copy link
Member

kennytm commented Jun 1, 2019

r=me after czipperz's comment is fixed.

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019
@Centril
Copy link
Contributor

Centril commented Jun 10, 2019

Ping from triage @bekicot ^---

@bekicot
Copy link
Author

bekicot commented Jun 13, 2019

@Centril Sorry for the delay. Currently having a very slow internet connection (on vacation). Cant clone the repository to do the required amend. Be back tomorrow and will resolve.

@jonas-schievink
Copy link
Contributor

Triage ping @bekicot, this still needs the tiny change above

@joelpalmer
Copy link

@rustbot modify labels to +S-inactive-closed and -S-waiting-on-author

From Triage: @bekicot Closing due to inactivity. Please re-open before pushing changes. Thank you for the PR.

@rustbot rustbot added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2019
@ghost ghost mentioned this pull request Oct 5, 2019
Merged
tmandry added a commit to tmandry/rust that referenced this pull request Oct 5, 2019
@tmandry
Rollup merge of rust-lang#65126 - BO41:time_typo, r=kennytm
07ee1e2 
Fix typo on `now()` comments

Fix typo, update words, and remove some redundant word.
Also rustfmt on the rest of the file (hope this is okay :)

revival of rust-lang#61433

r? @kennytm
tmandry added a commit to tmandry/rust that referenced this pull request Oct 6, 2019
@tmandry
Rollup merge of rust-lang#65126 - BO41:time_typo, r=kennytm
d54082e 
Fix typo on `now()` comments

Fix typo, update words, and remove some redundant word.
Also rustfmt on the rest of the file (hope this is okay :)

revival of rust-lang#61433

r? @kennytm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czipperz czipperz czipperz left review comments

Assignees

@kennytm kennytm

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bekicot @rust-highfive @tesuji @kennytm @Centril @jonas-schievink @joelpalmer @czipperz @Dylan-DPC-zz @rustbot