Remove promoted intrinsics caller type checking from const context #61493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @oli-obk |
|
So this does not fix the bug that we allow calling intrinsics in |
Removed part will be added to rust/src/librustc_mir/transform/qualify_consts.rs Lines 1228 to 1230 in 7096ff0 visit_terminator_kind. That will fix the bug seems like.
|
eddyb
reviewed
Jun 3, 2019
| => return true, | ||
|
|
||
| _ => {} | ||
| } |
There was a problem hiding this comment.
@oli-obk We still need a PR that fixes this code and adds a test.
|
ping from triage @eddyb @vertexclique @oli-obk any updates? |
|
This can be closed, we are not going to use this. We have different PR to solve this one. |
|
@vertexclique which PR is that? Is it #61835 ? |
|
Yes, it's that. It will be here: #61835 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes promoting intrinsics that checks the caller type in
const context. PR linked to issue defined in #61399 (comment)