-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression 61475 #61500
Fix regression 61475 #61500
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -628,10 +628,10 @@ impl<'a> Parser<'a> { | |
} | ||
_ => { | ||
Err(if self.prev_token_kind == PrevTokenKind::DocComment { | ||
self.span_fatal_err(self.prev_span, Error::UselessDocComment) | ||
} else { | ||
self.expected_ident_found() | ||
}) | ||
self.span_fatal_err(self.prev_span, Error::UselessDocComment) | ||
} else { | ||
self.expected_ident_found() | ||
}) | ||
} | ||
} | ||
} | ||
|
@@ -1660,8 +1660,8 @@ impl<'a> Parser<'a> { | |
path = self.parse_path(PathStyle::Type)?; | ||
path_span = path_lo.to(self.prev_span); | ||
} else { | ||
path = ast::Path { segments: Vec::new(), span: DUMMY_SP }; | ||
path_span = self.span.to(self.span); | ||
path = ast::Path { segments: Vec::new(), span: path_span }; | ||
} | ||
|
||
// See doc comment for `unmatched_angle_bracket_count`. | ||
|
@@ -2847,7 +2847,11 @@ impl<'a> Parser<'a> { | |
// want to keep their span info to improve diagnostics in these cases in a later stage. | ||
(true, Some(AssocOp::Multiply)) | // `{ 42 } *foo = bar;` or `{ 42 } * 3` | ||
(true, Some(AssocOp::Subtract)) | // `{ 42 } -5` | ||
(true, Some(AssocOp::Add)) => { // `{ 42 } + 42 | ||
(true, Some(AssocOp::LAnd)) | // `{ 42 } &&x` (#61475) | ||
(true, Some(AssocOp::Add)) // `{ 42 } + 42 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
// If the next token is a keyword, then the tokens above *are* unambiguously incorrect: | ||
// `if x { a } else { b } && if y { c } else { d }` | ||
if !self.look_ahead(1, |t| t.is_reserved_ident()) => { | ||
Comment on lines
+2852
to
+2854
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was the intention here to catch There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, this seems coincidental to #74233, and not actually a bug in itself. |
||
// These cases are ambiguous and can't be identified in the parser alone | ||
let sp = self.sess.source_map().start_point(self.span); | ||
self.sess.ambiguous_block_expr_parse.borrow_mut().insert(sp, lhs.span); | ||
|
@@ -5298,7 +5302,7 @@ impl<'a> Parser<'a> { | |
let mut where_clause = WhereClause { | ||
id: ast::DUMMY_NODE_ID, | ||
predicates: Vec::new(), | ||
span: DUMMY_SP, | ||
span: self.prev_span.to(self.prev_span), | ||
}; | ||
|
||
if !self.eat_keyword(kw::Where) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// run-pass | ||
#![allow(dead_code)] | ||
|
||
enum E { | ||
A, B | ||
} | ||
|
||
fn main() { | ||
match &&E::A { | ||
&&E::A => { | ||
} | ||
&&E::B => { | ||
} | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are included, why isn't
{ 42 } & 3
? Surely the have the same property?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this seems like a reporting-only heuristic and only the
can_continue_expr_unambiguously
check is relevant to what I was seeing.