-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mentions of IRC with Discord #61531
Conversation
Signed-off-by: Radu M <root@radu.sh>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits to use https over http
(I don't have perms to give final approval, though)
@@ -419,7 +418,7 @@ Find a [requested community library][community-library], build it, and publish | |||
it to [Crates.io](http://crates.io). Easier said than done, but very, very | |||
valuable! | |||
|
|||
[pound-rust]: http://chat.mibbit.com/?server=irc.mozilla.org&channel=%23rust | |||
[rust-discord]: http://discord.gg/rust-lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rust-discord]: http://discord.gg/rust-lang | |
[rust-discord]: https://discord.gg/rust-lang |
[IRC]: https://en.wikipedia.org/wiki/Internet_Relay_Chat | ||
[#rust]: irc://irc.mozilla.org/rust | ||
[#rust-beginners]: irc://irc.mozilla.org/rust-beginners | ||
[rust-discord]: http://discord.gg/rust-lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rust-discord]: http://discord.gg/rust-lang | |
[rust-discord]: https://discord.gg/rust-lang |
internals.rust-lang.org. When you encounter bugs, please file issues on the | ||
rust-lang/rust issue tracker. | ||
|
||
[rust-discord]: http://discord.gg/rust-lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rust-discord]: http://discord.gg/rust-lang | |
[rust-discord]: https://discord.gg/rust-lang |
Note: #rust-libs is still active as a team venue (as is #rust-embedded), they're going to find a new place to go before Mozilla IRC shuts down (there's still time). Furthermore, #rust, #rust-beginners, and #rust-internals are also somewhat active: I plan to lock them at some point to nudge people to Discord/Freenode, but that's not done yet, and the CoC still applies there. |
I've added this to the core team agenda to discuss on Wednesday; I think we'll probably want to just add Discord versus replacing IRC with it from the CoC. |
I'm surprised Discord isn't on there already, it is on the website: https://www.rust-lang.org/policies/code-of-conduct |
We discussed this a bit during the core team meeting today and decided that we should remove the code of conduct itself from this repository and instead simply link to https://www.rust-lang.org/policies/code-of-conduct. That way there's a canonical version that we can update without having to update numerous repositories. We'll want to edit the website to include IRC as well. |
One small note about this: we should keep the files, but have them say "the text lives at this URL". GitHub will say that the project does not have a code of conduct without the file existing. |
@radu-matei you have nits to solve. |
Hi @radu-matei - this is a ping from Triage. Are there any updates on this? |
ping from triage @radu-matei |
Replace mentions of IRC with Discord Revival of rust-lang#61531 closes rust-lang#61524 what was the outcome of this? rust-lang#61531 (comment) should this be changed in this PR as well? rust-lang#61531 (comment)
Replace mentions of IRC with Discord Revival of rust-lang#61531 closes rust-lang#61524 what was the outcome of this? rust-lang#61531 (comment) should this be changed in this PR as well? rust-lang#61531 (comment)
Replace mentions of IRC with Discord Revival of rust-lang#61531 closes rust-lang#61524 what was the outcome of this? rust-lang#61531 (comment) should this be changed in this PR as well? rust-lang#61531 (comment)
Replace mentions of IRC with Discord Revival of rust-lang#61531 closes rust-lang#61524 what was the outcome of this? rust-lang#61531 (comment) should this be changed in this PR as well? rust-lang#61531 (comment)
@Mark-Simulacrum this never got addressed, right? Is there still an interest? |
I think so, yes. I'm happy to review a PR to relevant repositories. |
…crum Replace code of conduct with link This will replace the code of conduct and link to a single version at https://www.rust-lang.org/conduct.html Fixes rust-lang#61531 (comment) r? @Mark-Simulacrum
closes #61524
One occurrence that requires more attention is in the code of conduct - please make sure it is correctly worded.
Happy to get feedback and reword any other change made.
Thanks!