libunwind: use correct compiler for cross compilation #61544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hmm, actually the change wasn't properly tested, fixing it. |
|
Works fine in one of my two environments and not in another one, still digging, but at least that's an improvement, as it worked on none of those before |
Fixes rust-lang#59917 Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
Thanks for the PR, but I don't think that this is the best way to solve the issue since the build script should already be using |
|
@alexcrichton In my case, i'm building from x86_64 a rustc with both x86_64 and i686 targets. CC, AR, etc env vars point to the x86_64 compiler, are picked by I don't have enough time right now but I'll provide logs with and without the patch so you can see the difference. |
|
Logs without the patch (in a clean environment which doesn't set the CC & friends env vars) |
|
Relevant parts of config.toml: |
|
Logs with the patch applied: |
|
Now, in an environment (our package manager) which sets a lot of env vars such as CC, LD, AR and friends, it still fails (at link time though, not the same failure), didn't find the reason yet. But as it builds just fine in a "clean" environment, that's already a great progress. I'm 100% fine with doing all this differently, I just posted that to gather some cmoments about how the proper way would look like. At least it shows that if we |
|
The fail I'm seeing when building from our package manager (beta branch) with the patch applied. Relevant env set by the package manager: |
|
It looks like this is doing something that basically isn't well supported now which is to enable the compilation of libunwind. That requires a C++ compiler but the C++ compiler isn't properly configured in rustbuild for libstd, just for the rustc build and beyond (because historically only LLVM needed a C++ compiler). The fix for this is to handle that somehow, not by introducing yet-another-new-env-var to convey compiler information. |
|
Last failure was actually caused by lld, works fine with gold. I'll see how these are set for the rustc build and try to move those definitions around so that libstd can use them too |
|
Ok, now I'm really puzzled. It seems that the env is actually here, as expected, so why isn't it used by |
|
Oh, CC, AR, CFLAGS are there but CXX isn't |
Keruspe
added a commit
to Keruspe/rust
that referenced
this pull request
Jun 12, 2019
Replaces rust-lang#61544 Fixes rust-lang#59917 We need CXX to build llvm-libunwind which can be enabled for all targets. As we needed it for all hosts anyways, just move the detection so that it is ran for all targets (which contains all hosts) instead. Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 7, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
bors
added a commit
that referenced
this pull request
Aug 15, 2019
Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in #61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 15, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 16, 2019
…hton Use libunwind from llvm-project submodule for musl targets This avoid downloading libunwind by using the scheme introduced in rust-lang#61544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59917