get rid of visit_place recursion #61653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
spastorino
reviewed
Jun 8, 2019
src/librustc/mir/visit.rs
Outdated
| location: Location) { | ||
| // this is calling `super_place` in preparation for changing `Place` to be | ||
| // a struct with a base and a slice of projections. `visit_place` should only ever | ||
| // be called for the base place now. |
There was a problem hiding this comment.
Would try to be more clear that you meant the root Place here.
oli-obk
force-pushed
the
visit_place_recursion
branch
from
408dea8 to
b137a47
Compare
|
@bors r+ |
|
📌 Commit b137a47 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 9, 2019
get rid of visit_place recursion r? @spastorino this is groundwork for #60913, since after that PR we won't be able to implement `visit_place` in a recursive manner without heavy cloning everywhere. cc @eddyb this touches const qualif
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Jun 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @spastorino
this is groundwork for #60913, since after that PR we won't be able to implement
visit_placein a recursive manner without heavy cloning everywhere.cc @eddyb this touches const qualif