-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable toolstate tracking on Azure #61772
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
So I think I've got everything hooked up right, but I've surely forgotten something. Hopefully it won't cause too many issues! cc @kennytm as well |
7809ed4
to
48e37b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd personally prefer to configure the issues URL and the delinking with environment variables instead of if
s in the code: this way we can do the Travis -> Azure switch without having to land PRs on the repo. Feel free to bikeshed the variable names.
Oh, variables are also missing on the master pipeline: variables:
- group: prod-credentials |
48e37b3
to
db30fa0
Compare
I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that... In any case everything else should be addressed! re-r? @pietroalbini I'll open an issue after this lands. |
Currently just run it through its paces but don't actually push to official locations. Instead let's just push to a separate fork (mine) as well as open issues in a separate fork (mine). Make sure that people aren't pinged for these issues as well! This should hopefully ensure that everything is working on Azure and give us a chance to work through any issues that come up.
db30fa0
to
521edee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks!
I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that...
The way I understand it is that to use a variable group in a pipeline you have to declare it in the YAML. If the variable group is marked as "available to all pipelines" in the UI then that's all, otherwise you also have to authorize it from the UI as a security measure.
@bors r+ p=1 rollup=never |
📌 Commit 521edee has been approved by |
ci: Enable toolstate tracking on Azure Currently just run it through its paces but don't actually push to official locations. Instead let's just push to a separate fork (mine) as well as open issues in a separate fork (mine). Make sure that people aren't pinged for these issues as well! This should hopefully ensure that everything is working on Azure and give us a chance to work through any issues that come up. Fixes #61790 Fixes #61371
☀️ Test successful - checks-travis, status-appveyor |
Looks like https://github.com/alexcrichton/rust-toolstate is receiving commits, but comments are failing on the master branch (https://dev.azure.com/rust-lang/rust/_build/results?buildId=716), will look into those now. |
Oh actually I think that that's an expected error. It's trying to create a comment on a PR in my repository, but that PR doesn't exist because it only exists in this repository. |
Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!
This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.
Fixes #61790
Fixes #61371