Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable toolstate tracking on Azure #61772

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Jun 12, 2019

Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!

This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.

Fixes #61790
Fixes #61371

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2019
@alexcrichton
Copy link
Member Author

r? @pietroalbini

So I think I've got everything hooked up right, but I've surely forgotten something. Hopefully it won't cause too many issues!

cc @kennytm as well

@alexcrichton alexcrichton force-pushed the pr-and-master-builds branch 2 times, most recently from 7809ed4 to 48e37b3 Compare June 12, 2019 18:39
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally prefer to configure the issues URL and the delinking with environment variables instead of ifs in the code: this way we can do the Travis -> Azure switch without having to land PRs on the repo. Feel free to bikeshed the variable names.

.azure-pipelines/pr.yml Show resolved Hide resolved
src/tools/publish_toolstate.py Outdated Show resolved Hide resolved
src/tools/publish_toolstate.py Show resolved Hide resolved
@pietroalbini
Copy link
Member

Oh, variables are also missing on the master pipeline:

variables:
- group: prod-credentials

@pietroalbini pietroalbini added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2019
@alexcrichton
Copy link
Member Author

I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that...

In any case everything else should be addressed!

re-r? @pietroalbini

I'll open an issue after this lands.

Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!

This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks!

I continue to not really understand how those variable groups work. I clicked "link" in the web UI but I don't think that was done for the auto branch, and I don't know what effect this yml configuration has over that...

The way I understand it is that to use a variable group in a pipeline you have to declare it in the YAML. If the variable group is marked as "available to all pipelines" in the UI then that's all, otherwise you also have to authorize it from the UI as a security measure.

@pietroalbini
Copy link
Member

@bors r+ p=1 rollup=never

@bors
Copy link
Contributor

bors commented Jun 13, 2019

📌 Commit 521edee has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 13, 2019
@bors
Copy link
Contributor

bors commented Jun 13, 2019

⌛ Testing commit 521edee with merge 0e4a56b...

bors added a commit that referenced this pull request Jun 13, 2019
ci: Enable toolstate tracking on Azure

Currently just run it through its paces but don't actually push to
official locations. Instead let's just push to a separate fork (mine) as
well as open issues in a separate fork (mine). Make sure that people
aren't pinged for these issues as well!

This should hopefully ensure that everything is working on Azure and
give us a chance to work through any issues that come up.

Fixes #61790
Fixes #61371
@bors
Copy link
Contributor

bors commented Jun 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: pietroalbini
Pushing 0e4a56b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 13, 2019
@bors bors merged commit 521edee into rust-lang:master Jun 13, 2019
@alexcrichton alexcrichton deleted the pr-and-master-builds branch June 14, 2019 14:16
@alexcrichton
Copy link
Member Author

Looks like https://github.com/alexcrichton/rust-toolstate is receiving commits, but comments are failing on the master branch (https://dev.azure.com/rust-lang/rust/_build/results?buildId=716), will look into those now.

@alexcrichton
Copy link
Member Author

Oh actually I think that that's an expected error. It's trying to create a comment on a PR in my repository, but that PR doesn't exist because it only exists in this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure: sccache not found azure: setup master and pr builds
5 participants