-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #61819
Rollup of 5 pull requests #61819
Conversation
Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
This commit extends the work in rust-lang#61698 to get the `DefId` of const parameters from block that resolve to a const parameter (as well as const parameters directly, as it was previously).
…crichton Pass LLVM linker flags to librustc_llvm build Some -L and -l flags may be needed even when building librustc_llvm, for example when using static libc++ on Linux we may need to manually specify the library search path and -ldl -lpthread as additional link dependencies. We pass LLVM linker flags from config to librustc_llvm build to make sure these cases are handled.
Add ui test for issue 51301 Closes rust-lang#51301
…enkov typeck: small refactoring, add 'fn write_resolution'
…expr-count-sequel, r=varkor typeck: Fix ICE for blocks in repeat expr count. Fixes rust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression. r? @varkor
Issue rust-lang#60709 test Adds a test for rust-lang#60709, which was fixed as part of rust-lang#59897. r? @cramertj
@bors r+ p=5 rollup=never |
📌 Commit 9b91bec has been approved by |
Rollup of 5 pull requests Successful merges: - #61704 (Pass LLVM linker flags to librustc_llvm build) - #61792 (Add ui test for issue 51301) - #61803 (typeck: small refactoring, add 'fn write_resolution') - #61805 (typeck: Fix ICE for blocks in repeat expr count.) - #61818 (Issue #60709 test) Failed merges: r? @ghost
💔 Test failed - checks-travis |
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
⌛ Testing commit 9b91bec with merge 7b31c270f2c361fb2c2e5b4dea5aa1cfc8be9c3b... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
Failed merges:
r? @ghost