Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #61823

Closed
wants to merge 8 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 14, 2019

Successful merges:

Failed merges:

r? @ghost

tesuji and others added 8 commits June 13, 2019 03:31
This commit extends the work in rust-lang#61698 to get the `DefId` of const
parameters from block that resolve to a const parameter (as well as
const parameters directly, as it was previously).
Update cargo

Update cargo

19 commits in 545f354259be4e9745ea00a524c0e4c51df01aa6..807429e1b6da4e2ec52488ef2f59e77068c31e1f
2019-05-23 17:45:30 +0000 to 2019-06-11 14:06:10 +0000
- Stabilize publish-lockfile. (rust-lang/cargo#7026)
- change package cache lock message (rust-lang/cargo#7029)
- Fix documenting an example. (rust-lang/cargo#7023)
- Fix nonconcurrent tests (rust-lang/cargo#6900)
- Update git2 crates for libgit2 0.28 (rust-lang/cargo#7018)
- fix bunch of clippy warnings (rust-lang/cargo#7019)
- Ignore remap-path-prefix in metadata hash. (rust-lang/cargo#6966)
- Don't synthesize feature diretives for non-optional deps (rust-lang/cargo#7010)
- Handle pipelined tests of libraries (rust-lang/cargo#7008)
- Import the cargo-vendor subcommand into Cargo (rust-lang/cargo#6869)
- Remove unnecessary outlives bounds (rust-lang/cargo#7000)
- Catch filename output collisions in rustdoc. (rust-lang/cargo#6998)
- the testing SAT solver was messed up by a refactor (rust-lang/cargo#6995)
- Add some hints to the docs for `cfg()` targets (rust-lang/cargo#6990)
- Test the Resolver against the varisat Library (rust-lang/cargo#6980)
- Update changelog. (rust-lang/cargo#6984)
- Update cache-messages tracking issue. (rust-lang/cargo#6987)
- zsh: Add --all-targets option to cargo-check and cargo-build (rust-lang/cargo#6985)
- Fix typo (rust-lang/cargo#6982)
…enkov

typeck: small refactoring, add 'fn write_resolution'
…expr-count-sequel, r=varkor

typeck: Fix ICE for blocks in repeat expr count.

Fixes rust-lang#61336 (again). This PR fixes an ICE that occured when a block expression resolving to a const generic was used for the count of an array repeat expression.

r? @varkor
@Centril
Copy link
Contributor Author

Centril commented Jun 14, 2019

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented Jun 14, 2019

📌 Commit 7934147 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 14, 2019
@bors
Copy link
Contributor

bors commented Jun 14, 2019

⌛ Testing commit 7934147 with merge 35b817687d601559ef46e8fa273da1b64db055f3...

@bors
Copy link
Contributor

bors commented Jun 14, 2019

💔 Test failed - checks-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2019
@rust-highfive
Copy link
Collaborator

The job dist-x86_64-musl of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:37:38] [RUSTC-TIMING] cargo_fmt test:false 14.689
[01:37:42] [RUSTC-TIMING] git_rustfmt test:false 18.168
[01:37:44] [RUSTC-TIMING] rustfmt test:false 19.769
[01:37:44]     Finished release [optimized] target(s) in 6m 20s
[01:37:44] duplicate artifacts found when compiling a tool, this typically means that something was recompiled because a transitive dependency has different features activated than in a previous build:
[01:37:44] the following dependencies are duplicated although they have the same features enabled:
[01:37:44] the following dependencies are duplicated although they have the same features enabled:
[01:37:44]   failure 0.1.5 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libfailure-dfdb55d8424618f5.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libfailure-c2b80a33144175bf.rlib")
[01:37:44]   serde 1.0.92 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libserde-201079034d802c6e.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libserde-08db5828731d83c9.rlib")
[01:37:44]   semver 0.9.0 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libsemver-9a0c1422779f4c1b.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libsemver-0cf9ea6cc13f0007.rlib")
[01:37:44]   rand_pcg 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand_pcg-7a5bd2cad3c530ab.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand_pcg-55bb30cafb29544d.rlib")
[01:37:44]   rand_chacha 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand_chacha-94d7240688ef2945.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand_chacha-17327c1445f7f60e.rlib")
[01:37:44]   serde_json 1.0.33 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libserde_json-d2f8d5876d97d75e.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libserde_json-8e1822fbefffd454.rlib")
[01:37:44]   toml 0.5.0 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libtoml-8a4f8d5322d715ca.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libtoml-a1cf0b5a714a0ad9.rlib")
[01:37:44]   rand 0.6.1 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand-68e2f5b4d394760b.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librand-16e80d7464516488.rlib")
[01:37:44]   parking_lot_core 0.4.0 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libparking_lot_core-b64674a674a503f2.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libparking_lot_core-ff37c2f3949cc050.rlib")
[01:37:44]   parking_lot 0.7.1 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libparking_lot-da88124b8b78ca98.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libparking_lot-713b7961156a5682.rlib")
[01:37:44]   openssl-sys 0.9.43 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libopenssl_sys-ba7bc02e1e222fba.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libopenssl_sys-c681161cfedf1477.rlib")
[01:37:44]   openssl 0.10.16 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libopenssl-cd173ebf7bbbcdd2.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libopenssl-e4f4a7f62ada7fe9.rlib")
[01:37:44]   curl-sys 0.4.18 (registry+https://github.com/rust-lang/crates.io-index)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libcurl_sys-62bb58ac1d16724b.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/libcurl_sys-1086a81ede1afc3e.rlib")
[01:37:44]   rustc-workspace-hack 1.0.0 (path+file:///checkout/src/tools/rustc-workspace-hack)
[01:37:44]     `rustfmt` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librustc_workspace_hack-536e3cf7d5e1e864.rlib")
[01:37:44]     `cargo` ("/checkout/obj/build/x86_64-unknown-linux-musl/stage1-tools/x86_64-unknown-linux-musl/release/deps/librustc_workspace_hack-8dca53b1e1254fab.rlib")
[01:37:44] the following dependencies have different features:
[01:37:44] 
[01:37:44] to fix this you will probably want to edit the local src/tools/rustc-workspace-hack/Cargo.toml crate, as that will update the dependency graph to ensure that these crates all share the same feature set
[01:37:44] thread 'main' panicked at 'tools should not compile multiple copies of the same crate', src/bootstrap/tool.rs:172:13
[01:37:44] travis_fold:end:stage1-rustfmt

[01:37:44] travis_time:end:stage1-rustfmt:start=1560484052873960602,finish=1560484433903042993,duration=381029082391

---
travis_time:end:005b9025:start=1560484435891575241,finish=1560484435901695891,duration=10120650
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:041ed5ec
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:22d66eca
travis_time:start:22d66eca
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0a934587
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril Centril mentioned this pull request Jun 14, 2019
@Centril Centril closed this Jun 14, 2019
@Centril Centril deleted the rollup-p5umchm branch June 14, 2019 03:56
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants