non_ascii_idents lint (part of RFC 2457)
#61883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
previously requested changes
Jun 16, 2019
| impl EarlyLintPass for NonAsciiIdents { | ||
| fn check_ident(&mut self, cx: &EarlyContext<'_>, ident: ast::Ident) { | ||
| if !ident.name.as_str().is_ascii() { | ||
| let mut err = cx.struct_span_lint( |
There was a problem hiding this comment.
No need to use let mut err = here; just chain .emit() onto cx.struct_span_lint(...).
| @@ -0,0 +1,11 @@ | |||
| #![feature(non_ascii_idents)] | |||
There was a problem hiding this comment.
Could you move this into a folder under ui/lint/ dedicated to RFC 2457 (since there are more lints to add later...)
Manishearth
approved these changes
Jun 16, 2019
|
merging this: |
|
📌 Commit 0ae61d8 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
dismissed
Centril’s stale review
the pr doesn't need to block on that. can be fixed in a separate PR
|
Thanks @Dylan-DPC. Although—I was planning to fix it! Sorry I've been so busy lately! |
|
@zackmdavis A follow up would be great. :) |
|
Don't worry. Your lack of time could be a gift for someone waiting for a chance to contribute to the language 😄 |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2019
…=Manishearth `non_ascii_idents` lint (part of RFC 2457) RFC 2457 [declares](https://github.com/rust-lang/rfcs/blob/121bbeff500c3274cea22c7e0ca176274d592646/text/2457-non-ascii-idents.md): "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default." (Part of rust-lang#55467.) r? @Manishearth
|
⌛ Testing commit 0ae61d8 with merge ac686e2d827323431587aa79ae6901abba6f1fce... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #61988) made this pull request unmergeable. Please resolve the merge conflicts. |
RFC 2457 declares: "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default."
zackmdavis
force-pushed
the
non_ascii_idents_lint
branch
from
0ae61d8
to
6de8e39
Compare
|
@bors r=Manishearth |
|
📌 Commit 6de8e39 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 7, 2019
…=Manishearth `non_ascii_idents` lint (part of RFC 2457) RFC 2457 [declares](https://github.com/rust-lang/rfcs/blob/121bbeff500c3274cea22c7e0ca176274d592646/text/2457-non-ascii-idents.md): "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default." (Part of rust-lang#55467.) r? @Manishearth
|
⌛ Testing commit 6de8e39 with merge 0ac1b84af9fd38d43c174a5a1222478cfaa6451e... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 7, 2019
…=Manishearth `non_ascii_idents` lint (part of RFC 2457) RFC 2457 [declares](https://github.com/rust-lang/rfcs/blob/121bbeff500c3274cea22c7e0ca176274d592646/text/2457-non-ascii-idents.md): "A `non_ascii_idents` lint is added to the compiler. This lint is allow by default." (Part of rust-lang#55467.) r? @Manishearth
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Jul 7, 2019
Rollup of 4 pull requests Successful merges: - #61883 (`non_ascii_idents` lint (part of RFC 2457)) - #62042 (Support stability and deprecation checking for all macros) - #62213 (rustdoc: set cfg(doctest) when collecting doctests) - #62286 (Check if the archive has already been added to avoid duplicates) Failed merges: r? @ghost
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2457 declares: "A
non_ascii_identslint is added to the compiler. This lint is allow by default."(Part of #55467.)
r? @Manishearth