Rollup of 10 pull requests #61943
Closed
Rollup of 10 pull requests #61943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ementors and Implementations on Foreign Types sections of trait documentation pages.
This tests takes nearly 5 minutes to compile on CI where the CPUs we have aren't exactly the fastest. This test does actually require all closures to exist to exhibit the original bug, but it seems a little excessive to test a single bug on CI on all platforms which simply pegs a single CPU for 5 minutes with no parallelism opportunities, so this turns down the test to still exercise it somewhat at least.
Tracking issue: rust-lang#60405
This commit checks in a script which generates CPU usage graphs over time, expanding on the previous comment that was include in the collection file.
Only show methods that appear in `impl` blocks in the Implementors sections of trait doc pages In the "Implementors" and "Implementations on Foreign Types" sections, only show methods that appear in the `impl` block for that type. This has the benefit of - Reducing the size of the Iterator page, and other large trait documentation pages. - Retaining documentation on the `impl` blocks and functions in the `impl` blocks. - Indicating which provided methods are overridden. - Making the documentation match the structure of the code being documented. - Being a small change that can be easily backed out if issues arise. A set of Rust stdlib docs build with this change are [available here](https://ebarnard.github.io/2019-06-03-rust-smaller-trait-implementers-docs/). The size of the [`Iterator` doc page](https://ebarnard.github.io/2019-06-03-rust-smaller-trait-implementers-docs/std/iter/trait.Iterator.html) is reduced from 14.4MB (latest nightly) to 724kB. Before: <img width="1411" alt="Screenshot 2019-06-03 at 23 12 17" src="https://user-images.githubusercontent.com/1059683/58837971-1722a780-8655-11e9-8d81-51e48130951d.png"> After: <img width="1428" alt="Screenshot 2019-06-03 at 16 41 27" src="https://user-images.githubusercontent.com/1059683/58814907-84ffac80-861e-11e9-8692-79be473a5299.png"> cc rust-lang#55900
move stray run-pass const tests into const/ folder r? @oli-obk
Tweak transparent enums and unions diagnostic spans
…=cramertj Make MaybeUninit #[repr(transparent)] Tracking issue: rust-lang#60405
…r=pietroalbini ci: Add a script for generating CPU usage graphs This commit checks in a script which generates CPU usage graphs over time, expanding on the previous comment that was include in the collection file. Some example graphs from the [latest build](https://dev.azure.com/rust-lang/rust/_build/results?buildId=717) look like:    
Remove unnecessary lift calls Note that some of these might be useful for sanity checking that there's no infer types or regions. r? @eddyb
…s, r=pietroalbini Turn down the myriad-closures test This tests takes nearly 5 minutes to compile on CI where the CPUs we have aren't exactly the fastest. This test does actually require all closures to exist to exhibit the original bug, but it seems a little excessive to test a single bug on CI on all platforms which simply pegs a single CPU for 5 minutes with no parallelism opportunities, so this turns down the test to still exercise it somewhat at least.
…nkov rustc_typeck: correctly compute `Substs` for `Res::SelfCtor`. Fixes rust-lang#61882. r? @petrochenkov cc @varkor
syntax: Factor out common fields from `SyntaxExtension` variants And some other related cleanups. Continuation of rust-lang#61606. This will also help to unblock rust-lang#61877.
create an issue for miri even in status test-fail I fired up python to see that this parses, but I wouldn't know how to test this script.
|
@bors r+ p=10 rollup=never |
|
📌 Commit 0b8da29 has been approved by |
bors
added
the
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
implblocks in the Implementors sections of trait doc pages #61505 (Only show methods that appear inimplblocks in the Implementors sections of trait doc pages)SubstsforRes::SelfCtor. #61896 (rustc_typeck: correctly computeSubstsforRes::SelfCtor.)SyntaxExtensionvariants #61898 (syntax: Factor out common fields fromSyntaxExtensionvariants)Failed merges:
r? @ghost