rustc: use a separate copy of P for HIR than for AST. #61995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-author
|
@petrochenkov Rebased and fixed nits. |
|
@bors r+ |
|
📌 Commit c6374cf has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit c6374cf with merge 6a21be2954d05f6fb1ebacfa69f78b2556eef00e... |
|
@bors retry Yielding priority to the Azure migration. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2019
rustc: use a separate copy of P for HIR than for AST. Note: this currently includes/is based on top of rust-lang#61987. Like rust-lang#61968, but goes one step further and uses a separate `P<...>` for the HIR, with no `Clone`, or the ability to mutate after allocation. There is still `into_inner`/`into_iter`, but they're only exposed for `hir::lowering`, and they would take more work to untangle. r? @petrochenkov cc @rust-lang/compiler
|
⌛ Testing commit c6374cf with merge 191b6d1b778c55ec8f274dbc562479af66aa9d8b... |
|
@bors retry Yielding priority to the stable rebuild. |
bors
added a commit
that referenced
this pull request
Jul 3, 2019
rustc: use a separate copy of P for HIR than for AST. Note: this currently includes/is based on top of #61987. Like #61968, but goes one step further and uses a separate `P<...>` for the HIR, with no `Clone`, or the ability to mutate after allocation. There is still `into_inner`/`into_iter`, but they're only exposed for `hir::lowering`, and they would take more work to untangle. r? @petrochenkov cc @rust-lang/compiler
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
|
📣 Toolstate changed by #61995! Tested on commit 8c6fb02. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 3, 2019
Tested on commit rust-lang/rust@8c6fb02. Direct link to PR: <rust-lang/rust#61995> 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
matthiaskrgr
added a commit
to matthiaskrgr/rust-clippy
that referenced
this pull request
Jul 3, 2019
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 3, 2019
rustup rust-lang/rust#61995 changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 3, 2019
rustup rust-lang/rust#61995 changelog: none
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Jul 3, 2019
rustup rust-lang/rust#61995 changelog: none
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 4, 2019
Changes: ```` Remove unused import rustup rust-lang#61995 Fix allow bug in `trivially_copy_pass_by_ref` readme: fix urls in the license Fix `match_same_arms` false negative Reenable cargo and rls tests in travis Test for melted ICE rust-lang#4121 Fix `never_loop` false positive Running rustfmt on test Removed use of intrinsics::uninit from tests. Making try_err machine applicable PR comments Adding try_err lint ```` Fixes rust-lang#62338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this currently includes/is based on top of #61987.
Like #61968, but goes one step further and uses a separate
P<...>for the HIR, with noClone, or the ability to mutate after allocation.There is still
into_inner/into_iter, but they're only exposed forhir::lowering, and they would take more work to untangle.r? @petrochenkov cc @rust-lang/compiler