Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final nail in rand 0.4 coffin #62026

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Final nail in rand 0.4 coffin #62026

merged 1 commit into from
Jul 8, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Jun 21, 2019

Closes #57724

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 21, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 21, 2019

📌 Commit 886adfc7152157da8e5fac595ac17523fe9a08fd has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2019
@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2019
@jonas-schievink
Copy link
Contributor

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jun 22, 2019

📌 Commit 49408776bc987aec69839eb786d9c90ec2e195b9 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2019
@bors
Copy link
Contributor

bors commented Jun 22, 2019

⌛ Testing commit 49408776bc987aec69839eb786d9c90ec2e195b9 with merge e94a01c02fd666454abcdc1442df3e2757ccd44c...

@bors
Copy link
Contributor

bors commented Jun 22, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:46:11] test string::test_str_clear ... ok
[01:46:11] test string::test_str_truncate ... ok
[01:46:11] test string::test_str_truncate_invalid_len ... ok
[01:46:11] test string::test_str_truncate_split_codepoint ... ok
[01:46:11] died due to signal 11
[01:46:11] error: test failed, to rerun pass '-p alloc --test collectionstests'
[01:46:11] 
[01:46:11] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:46:11] expected success, got: exit code: 3
[01:46:11] 
---
travis_time:end:204a1808:start=1561216248753347049,finish=1561216248762893918,duration=9546869
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:163a9eb6
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0982c2d0
travis_time:start:0982c2d0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2031bf1c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 22, 2019
@mati865
Copy link
Contributor Author

mati865 commented Jun 25, 2019

Failed because of #55861, rebased.

@bors
Copy link
Contributor

bors commented Jun 30, 2019

☔ The latest upstream changes (presumably #61767) made this pull request unmergeable. Please resolve the merge conflicts.

@mati865
Copy link
Contributor Author

mati865 commented Jul 1, 2019

Rebased

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 1, 2019

📌 Commit 734d31a has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 1, 2019
@mati865
Copy link
Contributor Author

mati865 commented Jul 6, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit f1280a596517a8560b7bc0599f81bb1a17eb56da has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2019
@bors
Copy link
Contributor

bors commented Jul 7, 2019

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

  1. git checkout deps (switch to your branch)
  2. git fetch upstream master (retrieve the latest master)
  3. git rebase upstream/master -p (rebase on top of it)
  4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
  5. git push self deps --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message
warning: Cannot merge binary files: Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2019
@mati865 mati865 force-pushed the deps branch 2 times, most recently from a85607b to cd89226 Compare July 7, 2019 15:03
@mati865
Copy link
Contributor Author

mati865 commented Jul 7, 2019

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jul 7, 2019

📌 Commit cd8922689437a68fa37562f47e6e03268d4899c0 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2019
@bors
Copy link
Contributor

bors commented Jul 7, 2019

⌛ Testing commit cd8922689437a68fa37562f47e6e03268d4899c0 with merge 0d1a662deb737cc029a5959044944ff3e26a98f5...

@bors
Copy link
Contributor

bors commented Jul 7, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2019
@mati865
Copy link
Contributor Author

mati865 commented Jul 7, 2019

@bors r=alexcrichton

Forgot to run ./x.py after last rebase.

@bors
Copy link
Contributor

bors commented Jul 7, 2019

📌 Commit 2ac20e2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2019
@bors
Copy link
Contributor

bors commented Jul 7, 2019

⌛ Testing commit 2ac20e2 with merge a824723...

bors added a commit that referenced this pull request Jul 7, 2019
Final nail in `rand 0.4` coffin

Closes #57724
@bors
Copy link
Contributor

bors commented Jul 8, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: alexcrichton
Pushing a824723 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 8, 2019
@bors bors merged commit 2ac20e2 into rust-lang:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc is using three versions of rand
6 participants