Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clippy #62434

Merged
merged 1 commit into from
Jul 7, 2019
Merged

Update clippy #62434

merged 1 commit into from
Jul 7, 2019

Conversation

Manishearth
Copy link
Member

r? @ghost

@Manishearth
Copy link
Member Author

@bors r+ p=2

@bors
Copy link
Contributor

bors commented Jul 6, 2019

📌 Commit 36a67339d076634fdf548b1e12e24ca37431ffd7 has been approved by Manishearth

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 6, 2019
@matthiaskrgr
Copy link
Member

If #61988 merges, clippy will be broken again (regardless of this pr).

@tesuji tesuji mentioned this pull request Jul 6, 2019
Closed
@bors
Copy link
Contributor

bors commented Jul 6, 2019

⌛ Testing commit 36a67339d076634fdf548b1e12e24ca37431ffd7 with merge c8eafa56334528b48d394efe40d231b2bbdd777d...

@tesuji
Copy link
Contributor

tesuji commented Jul 6, 2019

@Centril Do you want to take a look to rustup clippy?

@bors
Copy link
Contributor

bors commented Jul 6, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2019
@Centril
Copy link
Contributor

Centril commented Jul 6, 2019 •
edited
Loading

@lzutao Don't have time for it right now. It should be relatively straightforward tho... make a "higher" function for resugaring while-loops (like as done for if-expressions) with the information you need using the desugaring information based on what is done in lowering.rs in my PR. Then proceed to use that higher function on HIR expressions and match on Some((the, information, you need)).

@Manishearth
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 7, 2019

📌 Commit e2885eb has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2019
@bors
Copy link
Contributor

bors commented Jul 7, 2019

⌛ Testing commit e2885eb with merge dbeed58...

bors added a commit that referenced this pull request Jul 7, 2019
@bors
Auto merge of #62434 - Manishearth:clippyup, r=Manishearth
dbeed58 
Update clippy

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 7, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: Manishearth
Pushing dbeed58 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2019
@bors bors merged commit e2885eb into rust-lang:master Jul 7, 2019
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #62434!

Tested on commit dbeed58.
Direct link to PR: #62434

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 7, 2019
@rust-highfive
📣 Toolstate changed by rust-lang/rust#62434!
906e819 
Tested on commit rust-lang/rust@dbeed58.
Direct link to PR: <rust-lang/rust#62434>

🎉 clippy-driver on windows: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @Manishearth @llogiq @mcarton @oli-obk @phansch, @rust-lang/infra).
@SimonSapin SimonSapin mentioned this pull request Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Manishearth @bors @matthiaskrgr @tesuji @Centril @rust-highfive