Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for #43398 #62994

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Add test for #43398 #62994

merged 1 commit into from
Aug 8, 2019

Conversation

iluuu1994
Copy link
Contributor

Closes #43398

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2019
@wirelessringo
Copy link

Ping from triage. @nikomatsakis please review. Thanks

@nikomatsakis
Copy link
Contributor

Can you move this test to src/test/ui/issues? You'll have to add a // run-pass comment at the top as well.

@iluuu1994
Copy link
Contributor Author

@nikomatsakis Done, tests passed 🙂

@nikomatsakis
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2019

📌 Commit ebc3600 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2019
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019
bors added a commit that referenced this pull request Aug 8, 2019
Rollup of 7 pull requests

Successful merges:

 - #62994 (Add test for #43398)
 - #63259 (Add tests for some issues)
 - #63327 (doc: Reword deprecation message of MetadataExt::as_raw_stat)
 - #63331 (Test conditional initialization validation in async fns)
 - #63334 (Update to rustc-guide that passes toolstate)
 - #63353 (Update books)
 - #63360 (Use consistent capitalization in -C/-Z help)

Failed merges:

r? @ghost
@bors bors merged commit ebc3600 into rust-lang:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE getting discriminant of #[repr(i128)] enum
5 participants