-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for #43398 #62994
Add test for #43398 #62994
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Ping from triage. @nikomatsakis please review. Thanks |
Can you move this test to |
bb09e5c
to
ebc3600
Compare
@nikomatsakis Done, tests passed 🙂 |
@bors r+ rollup |
📌 Commit ebc3600 has been approved by |
…sakis Add test for rust-lang#43398 Closes rust-lang#43398
…sakis Add test for rust-lang#43398 Closes rust-lang#43398
…sakis Add test for rust-lang#43398 Closes rust-lang#43398
Rollup of 7 pull requests Successful merges: - #62994 (Add test for #43398) - #63259 (Add tests for some issues) - #63327 (doc: Reword deprecation message of MetadataExt::as_raw_stat) - #63331 (Test conditional initialization validation in async fns) - #63334 (Update to rustc-guide that passes toolstate) - #63353 (Update books) - #63360 (Use consistent capitalization in -C/-Z help) Failed merges: r? @ghost
Closes #43398