-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "see issue" consistent #63008
Make "see issue" consistent #63008
Conversation
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some more inconsistencies that should be fixed (at least some of them):
See issue #49146 <https://github.com/rust-lang/rust/issues/49146> \
for more information.", kind),
for more information, see issue \
#57563 <https://github.com/rust-lang/rust/issues/57563>");
see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"
please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>
for more context, see issue #60210 <https://github.com/rust-lang/rust/issues/60210>
see issue #46062 <https://github.com/rust-lang/rust/issues/46062> for more details
I think, the order should be consistent, as well as the inclusion of "for more information/details"
I should've made this consistent as well. In this PR, I was only concerned about the consistency of Github links to the issues. |
r? @varkor |
I'll review this soon. However, I feel slightly uncomfortable, because @punitkoura had asked to take this issue. It would be a shame to waste this effort, though. If @punitkoura is happy with it, perhaps we could go with this pull request, but @punitkoura can be added as a co-author for doing the initial work? Then I can direct @punitkoura to another easy starter issue. |
☔ The latest upstream changes (presumably #63094) made this pull request unmergeable. Please resolve the merge conflicts. |
Hi @varkor, these changes look good to me. I was also working on the same, but then saw this PR and therefore didn't raise another PR. It'd be really nice if I could be added as a co-author though :) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
It'd be nice to normalise the following strings that appear:
I personally prefer "see [...] for more information", as it has the link early on. Apart from that, this looks good. If you could squash the |
@punitkoura don't you mind if I'll use your email |
☔ The latest upstream changes (presumably #63124) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@eupn, yes, that email id works |
☔ The latest upstream changes (presumably #63148) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Thanks! @bors r+ |
📌 Commit 7336626 has been approved by |
Make "see issue" consistent Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search. r? @varkor
@bors r+ |
📌 Commit 2ae06197c97b63466f7854421b8f9f61dd9fb2d2 has been approved by |
☔ The latest upstream changes (presumably #63180) made this pull request unmergeable. Please resolve the merge conflicts. |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Co-Authored-By: varkor <github@varkor.com>
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors p=1 since this is pretty conflict-prone |
@eupn: there have been more merge conflicts, so you'll need to rebase and force push again. |
☔ The latest upstream changes (presumably #63627) made this pull request unmergeable. Please resolve the merge conflicts. |
Ping from triage. @eupn any updates on this? Thanks. |
I’ll rebase it soon! |
Ping from triage: @eupn any updates on this? |
1 similar comment
Ping from triage: @eupn any updates on this? |
Ping from Triage: closing due to inactivity. Thanks for the PR @eupn! If you do rebase and have updates, please re-open. |
…, r=Dylan-DPC Make issue references consistent Fixes rust-lang#62976 cc rust-lang#63008 r? @varkor because you reviewed the original pr
Fixes #62976. h/t to @punitkoura for initial patterns search.
r? @varkor