-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the mention of LLDB from RELEASES.md #63192
Remove the mention of LLDB from RELEASES.md #63192
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
In that case let's not pull this in yet! I'll to arrange time tomorrow to see if it works and if it does, I'll close this and re-enable the LLDB build for macOS release :) |
Yes I believe the |
Er. Got entered early.
but again to recap gdb I have in my path rust-gdb which is a binary
and I have $(rustc --print sysroot)/bin/rust-gdb which is the wrapper script
if I use either one
or
I dont get pretty printing
but I DO if use either, or not at all, but simply load it myself
|
Ping from Triage: Hi @golddranks I am going to change this to waiting-on-author. If you are waiting for a reviewer on something or plan to close this, please respond. Thanks! |
I'm going to close this since it got released. |
Since #62592 (and rust-lang/llvm-project#19 ), building the lldb-preview component has been disabled and it's not currently shipped with the macOS components it used to be shipped with. Therefore it's misleading to say it's fixed in the release notes.
Now, I'm hoping that we could ship the component eventually, but the current status of it seems to be unclear: since the upgrade to LLVM 9, some Rust-specific patches on LLDB were outdated. I don't know if the pretty-printing scripts work without them and I don't have the time to test them right now. (The patches are here: https://github.com/nikic/llvm-project/commits/llvm-9-lldb ) Additionally, there is an open PR to replace the pretty printing scripts. I'm not sure about the status of that work, now that the Rust patches on LLDB were dropped, plus it seems to be WIP: #60826