Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #63311

Closed
wants to merge 37 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
56ebfb1
Implement DoubleEndedIterator for iter::{StepBy, Peekable, Take}
timvermeulen Jun 2, 2019
3b15b16
Explaining the reason why validation is performed in to_str of path.rs
JasonShin Aug 1, 2019
1aa4a57
Update src/libstd/path.rs to shorten the explanation for .to_str vali…
JasonShin Aug 1, 2019
50b258b
diagnostics: Describe crate root modules in `DefKind::Mod` as "crate"
petrochenkov Aug 3, 2019
416caa1
Add test for issue-29265
JohnTitor Aug 4, 2019
620567d
Add test for issue-49544
JohnTitor Aug 4, 2019
92e4e8e
Add test for issue-37433
JohnTitor Aug 4, 2019
0d15845
fix UB in a test
RalfJung Aug 4, 2019
95f29aa
Revert "Rollup merge of #62696 - chocol4te:fix_#62194, r=estebank"
arielb1 Aug 4, 2019
4e51ef7
Test content, not value
RalfJung Aug 5, 2019
b5e35b1
remove special code path for unknown tokens
matklad Jul 30, 2019
58ac81a
add unknown token
matklad Jul 30, 2019
b3e8c8b
adapt rustdoc to infailable lexer
matklad Jul 30, 2019
ab3fb1e
Drop span argument from mk_list_item
Mark-Simulacrum Aug 4, 2019
24a491f
Drop explicit span argument from mk_name_value_item
Mark-Simulacrum Aug 4, 2019
8849149
Make mk_attr_id private to libsyntax
Mark-Simulacrum Aug 4, 2019
fbf93d4
Remove leftover AwaitOrigin
Mark-Simulacrum Aug 5, 2019
90b95cf
fix slice comparison
RalfJung Aug 5, 2019
288b4e9
Don't store &Span
Mark-Simulacrum Aug 5, 2019
1f01863
improve align_offset docs
RalfJung Aug 5, 2019
30910ee
Make qualify consts in_projection use PlaceRef
spastorino Aug 5, 2019
9058bf2
Make use of possibly uninitialized data a hard error
tmandry Aug 3, 2019
571e22d
Clarify align_to's requirements and obligations
shepmaster Aug 5, 2019
7750dfe
Rollup merge of #61457 - timvermeulen:double_ended_iters, r=scottmcm
Centril Aug 6, 2019
e502615
Rollup merge of #63017 - matklad:no-fatal, r=petrochenkov
Centril Aug 6, 2019
3be2c9a
Rollup merge of #63184 - JasonShin:master, r=sfackler
Centril Aug 6, 2019
0f47687
Rollup merge of #63230 - tmandry:disallow-possibly-uninitialized, r=C…
Centril Aug 6, 2019
d7eab18
Rollup merge of #63250 - petrochenkov:descrate, r=davidtwco
Centril Aug 6, 2019
845bc4f
Rollup merge of #63259 - JohnTitor:add-tests-for-some-issues, r=Centril
Centril Aug 6, 2019
7a0dd84
Rollup merge of #63260 - RalfJung:ptr-test, r=matklad
Centril Aug 6, 2019
485aae0
Rollup merge of #63264 - arielb1:revert-private-coherence-errors, r=e…
Centril Aug 6, 2019
3619648
Rollup merge of #63272 - Mark-Simulacrum:clean-attr, r=petrochenkov
Centril Aug 6, 2019
f0e34c9
Rollup merge of #63285 - Mark-Simulacrum:rm-await-origin, r=Centril
Centril Aug 6, 2019
a13ff3d
Rollup merge of #63287 - Mark-Simulacrum:span-no-ref, r=Centril
Centril Aug 6, 2019
c668bb7
Rollup merge of #63293 - shepmaster:align-to-doc, r=@RalfJung
Centril Aug 6, 2019
53e3519
Rollup merge of #63295 - RalfJung:align_offset, r=dtolnay
Centril Aug 6, 2019
a988d59
Rollup merge of #63299 - spastorino:in-projection-use-ref, r=oli-obk
Centril Aug 6, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/libstd/path.rs to shorten the explanation for .to_str vali…
…dation step

Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
  • Loading branch information
JasonShin and Centril authored Aug 1, 2019
commit 1aa4a578276b2a3f7c47dcea7ad75786982550d4
2 changes: 1 addition & 1 deletion src/libstd/path.rs
Original file line number Diff line number Diff line change
@@ -1819,7 +1819,7 @@ impl Path {
/// Yields a [`&str`] slice if the `Path` is valid unicode.
///
/// This conversion may entail doing a check for UTF-8 validity.
/// Also it it worthwhile noting that validation is performed because Non-UTF-8 strings are
/// Note that validation is performed because non-UTF-8 strings are
/// perfectly valid for some OS.
///
/// [`&str`]: ../primitive.str.html