Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More explicit diagnostic when using a vec![] in a pattern #63399

Merged
merged 2 commits into from
Aug 10, 2019
Merged

More explicit diagnostic when using a vec![] in a pattern #63399

merged 2 commits into from
Aug 10, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Aug 9, 2019 

error: unexpected `(` after qualified path
  --> $DIR/vec-macro-in-pattern.rs:3:14
   |
LL |         Some(vec![x]) => (),
   |              ^^^^^^^
   |              |
   |              unexpected `(` after qualified path
   |              in this macro invocation
   |              use a slice pattern here instead
   |
   = help: for more information, see https://doc.rust-lang.org/edition-guide/rust-2018/slice-patterns.html
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

Fix #61933.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2019
@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2019

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Aug 9, 2019
Centril
Centril reviewed Aug 9, 2019
View reviewed changes
src/libsyntax/ext/tt/macro_rules.rs Outdated Show resolved Hide resolved
src/libsyntax/ext/tt/macro_rules.rs Outdated Show resolved Hide resolved
@Centril Centril self-assigned this Aug 9, 2019
@estebank
More explicit diagnostic when using a vec![] in a pattern
7c96d90 
```
error: unexpected `(` after qualified path
  --> $DIR/vec-macro-in-pattern.rs:3:14
   |
LL |         Some(vec![x]) => (),
   |              ^^^^^^^
   |              |
   |              unexpected `(` after qualified path
   |              in this macro invocation
   |              use a slice pattern here instead
   |
   = help: for more information, see https://doc.rust-lang.org/edition-guide/rust-2018/slice-patterns.html
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
```
@Centril
Copy link
Contributor

Centril commented Aug 9, 2019

r=me if you want with issue filed + refactoring :)

@estebank estebank mentioned this pull request Aug 9, 2019
Closed
@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2019

@bors r=Centril

@bors
Copy link
Contributor

bors commented Aug 9, 2019

📌 Commit 75c5ad2 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2019
@estebank
Copy link
Contributor Author

estebank commented Aug 9, 2019

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019
@Centril
Rollup merge of rust-lang#63399 - estebank:vec-in-pat, r=Centril
a873606 
More explicit diagnostic when using a `vec![]` in a pattern

```
error: unexpected `(` after qualified path
  --> $DIR/vec-macro-in-pattern.rs:3:14
   |
LL |         Some(vec![x]) => (),
   |              ^^^^^^^
   |              |
   |              unexpected `(` after qualified path
   |              in this macro invocation
   |              use a slice pattern here instead
   |
   = help: for more information, see https://doc.rust-lang.org/edition-guide/rust-2018/slice-patterns.html
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
```

Fix rust-lang#61933.
@Centril Centril mentioned this pull request Aug 9, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Aug 10, 2019
@Centril
Rollup merge of rust-lang#63399 - estebank:vec-in-pat, r=Centril
9ece794 
More explicit diagnostic when using a `vec![]` in a pattern

```
error: unexpected `(` after qualified path
  --> $DIR/vec-macro-in-pattern.rs:3:14
   |
LL |         Some(vec![x]) => (),
   |              ^^^^^^^
   |              |
   |              unexpected `(` after qualified path
   |              in this macro invocation
   |              use a slice pattern here instead
   |
   = help: for more information, see https://doc.rust-lang.org/edition-guide/rust-2018/slice-patterns.html
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
```

Fix rust-lang#61933.
@Centril Centril mentioned this pull request Aug 10, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Aug 10, 2019
@Centril
Rollup merge of rust-lang#63399 - estebank:vec-in-pat, r=Centril
9e613c7 
More explicit diagnostic when using a `vec![]` in a pattern

```
error: unexpected `(` after qualified path
  --> $DIR/vec-macro-in-pattern.rs:3:14
   |
LL |         Some(vec![x]) => (),
   |              ^^^^^^^
   |              |
   |              unexpected `(` after qualified path
   |              in this macro invocation
   |              use a slice pattern here instead
   |
   = help: for more information, see https://doc.rust-lang.org/edition-guide/rust-2018/slice-patterns.html
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
```

Fix rust-lang#61933.
@Centril Centril mentioned this pull request Aug 10, 2019
Merged
bors added a commit that referenced this pull request Aug 10, 2019
@bors
Auto merge of #63428 - Centril:rollup-c2ru1z1, r=Centril
d19a359 
Rollup of 7 pull requests

Successful merges:

 - #63056 (Give built-in macros stable addresses in the standard library)
 - #63337 (Tweak mismatched types error)
 - #63350 (Use associated_type_bounds where applicable - closes #61738)
 - #63394 (Add test for issue 36804)
 - #63399 (More explicit diagnostic when using a `vec![]` in a pattern)
 - #63419 (check against more collisions for TypeId of fn pointer)
 - #63423 (Mention that tuple structs are private if any of their fields are)

Failed merges:

r? @ghost
@bors bors merged commit 75c5ad2 into rust-lang:master Aug 10, 2019
@oli-obk oli-obk mentioned this pull request Dec 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The vec![..] macro can be used in pattern position with bad diagnostics
6 participants
@estebank @rust-highfive @Centril @bors @eddyb @oli-obk