Rollup of 8 pull requests #63471

Mark-Simulacrum · 2019-08-11T19:18:51Z

Successful merges:

Add #[repr(transparent)] for several types #61969 (Add #[repr(transparent)] for several types)
Lint on some incorrect uses of mem::zeroed / mem::uninitialized #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized)
Miri shouldn't look at types #63433 (Miri shouldn't look at types)
rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE)
Derive Debug for CrateInfo #63441 (Derive Debug for CrateInfo)
Add an example to show how to insert item to a sorted vec #63442 (Add an example to show how to insert item to a sorted vec)
rustdoc: general cleanup #63453 (rustdoc: general cleanup)
Copy ty::Instance instead of passing by reference #63464 (Copy ty::Instance instead of passing by reference)

Failed merges:

Curtesy of petrochenkov

tcx.crate_name is the appropriate way to retrieve the crate name.

This drops the parking_lot dependency; the ReentrantMutex type appeared to be unused (at least, no compilation failures occurred). This is technically a possible change in behavior of its users, as lock() would wait on other threads releasing their guards, but since we didn't actually remove any threading or such in this code, it appears that we never used that behavior (the behavior change is only noticeable if the type previously was used in two threads, in a single thread ReentrantMutex is useless).

This is already a query so we're just needlessly copying the data around.

These impls prevent ergonomic use of the config (e.g., forcing us to use RefCell) despite all usecases for these structs only using their Display impls once.

Utilize `?` instead of and_then/map operators

ty::Instance is small and Copy, we should not be adding additional indirection.

Add #[repr(transparent)] for several types In some functions, types mentioned in this PR are transmuted into their inner value. Example for `PathBuf`: https://github.com/rust-lang/rust/blob/master/src/libstd/path.rs#L1132. This PR adds `#[repr(transparent)]` to those types, so their correct behavior doesn't depend on compiler details. (As far as I understand, currently that line, converting `PathBuf` to `Vec<u8>`, is UB).

Lint on some incorrect uses of mem::zeroed / mem::uninitialized Cc rust-lang#62825 and https://internals.rust-lang.org/t/make-mem-uninitialized-and-mem-zeroed-panic-for-some-types-where-0-is-a-niche/10605 This does not yet handle `NonNull`/`NonZero*`, but it is a start. I also improved some doc issues I hit on the way, and added a useful helper to `TyS`. EDIT: I added the relnotes label mostly as a proposal -- I think this is worth mentioning, but leave the decision up to the release team.

@oli-obk

Miri shouldn't look at types r? @oli-obk Fixes rust-lang#62137

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE This matches `RUSTC_LOG`. Both affect only rustc, not any Rust program.

Derive Debug for CrateInfo

@Mark-Simulacrum

…k-Simulacrum Add an example to show how to insert item to a sorted vec Closes rust-lang#61684 cc rust-lang#61742 r? @Mark-Simulacrum, @jonas-schievink

…GuillaumeGomez rustdoc: general cleanup Almost all commits stand alone; but all commits can be reviewed individually.

@eddyb

…ddyb Copy ty::Instance instead of passing by reference ty::Instance is small and Copy, we should not be adding additional indirection. Fixes rust-lang#63409. r? @eddyb

Mark-Simulacrum · 2019-08-11T19:19:02Z

@bors r+ p=10

bors · 2019-08-11T19:19:03Z

📌 Commit 4229dc3 has been approved by Mark-Simulacrum

bors · 2019-08-11T19:19:40Z

⌛ Testing commit 4229dc3 with merge 00ee1b4...

@ghost

Rollup of 8 pull requests Successful merges: - #61969 (Add #[repr(transparent)] for several types) - #63346 (Lint on some incorrect uses of mem::zeroed / mem::uninitialized) - #63433 (Miri shouldn't look at types) - #63440 (rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE) - #63441 (Derive Debug for CrateInfo) - #63442 (Add an example to show how to insert item to a sorted vec) - #63453 (rustdoc: general cleanup) - #63464 (Copy ty::Instance instead of passing by reference) Failed merges: r? @ghost

bors · 2019-08-11T22:52:46Z

☀️ Test successful - checks-azure
Approved by: Mark-Simulacrum
Pushing 00ee1b4 to master...

MikailBag and others added 30 commits August 9, 2019 17:41

Add FIXME-s that some types should be transparent

740f8db

Miri shouldn't look at types

03e95ae

fix test

62f1e8a

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE

440a5c8

Derive Debug for CrateInfo

d809d6e

Add an example to show how to insert item to a sorted vec

93839c3

Use Result::unwrap_or_else instead of matching

30ba4bd

add basic lint testing for misuse of mem::zeroed and mem::uninitialized

da6fbb1

warn for more cases

ca1e94b

fix a comment

fbd5613

add tuple_fields convenience method and use it in a few places

8e6fbbe

note a FIXME

4b062a1

proper doc comment for 'recovered' field of variant

3972d05

Curtesy of petrochenkov

allow the lint if a few UB-demonstrating doc tests

c5a6356

note down some more future plans

5c77a17

update clippy

0930747

rustdoc: Replace HirVec with slices in doctree

65ea7b7

Move def_id_to_path to use site in visit_ast

19c85a8

Remove crate_name from DocContext

00d7bc7

tcx.crate_name is the appropriate way to retrieve the crate name.

Use entry API in store_path

8f80a8d

Replace Arc with Rc around external_traits

6be2857

Store typed Passes

0031951

Don't store all traits in DocContext

0347480

This is already a query so we're just needlessly copying the data around.

Use a HashSet instead of Vec

eea2f87

Remove unnecessary channel

ade8b02

Remove thread-local for playground config

dbad77f

Remove fmt::Display impls on Markdown structs

c250b5f

These impls prevent ergonomic use of the config (e.g., forcing us to use RefCell) despite all usecases for these structs only using their Display impls once.

Drop RefCell from IdMap in markdown rendering

1aa0964

Reduce nesting in externalfiles implementation

3b8a24d

Utilize `?` instead of and_then/map operators

bjorn3 and others added 10 commits August 11, 2019 16:51

Derive Debug for NativeLibrary and NativeLibraryKind

b204232

Copy ty::Instance instead of passing by reference

43de341

ty::Instance is small and Copy, we should not be adding additional indirection.

Rollup merge of rust-lang#63433 - RalfJung:miri-call, r=oli-obk

24a8337

Miri shouldn't look at types r? @oli-obk Fixes rust-lang#62137

Rollup merge of rust-lang#63440 - RalfJung:ctfe-backtrace, r=oli-obk

8122a01

rename RUST_CTFE_BACKTRACE to RUSTC_CTFE_BACKTRACE This matches `RUSTC_LOG`. Both affect only rustc, not any Rust program.

Rollup merge of rust-lang#63441 - bjorn3:patch-1, r=Mark-Simulacrum

c805a38

Derive Debug for CrateInfo

Rollup merge of rust-lang#63442 - lzutao:vec-bin-search-insert, r=Mar…

e16b12f

…k-Simulacrum Add an example to show how to insert item to a sorted vec Closes rust-lang#61684 cc rust-lang#61742 r? @Mark-Simulacrum, @jonas-schievink

Rollup merge of rust-lang#63453 - Mark-Simulacrum:rustdoc-clean-2, r=…

86ceab4

…GuillaumeGomez rustdoc: general cleanup Almost all commits stand alone; but all commits can be reviewed individually.

Rollup merge of rust-lang#63464 - Mark-Simulacrum:deref-instance, r=e…

4229dc3

…ddyb Copy ty::Instance instead of passing by reference ty::Instance is small and Copy, we should not be adding additional indirection. Fixes rust-lang#63409. r? @eddyb

Mark-Simulacrum closed this Aug 11, 2019

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 11, 2019

Mark-Simulacrum reopened this Aug 11, 2019

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 11, 2019

This was referenced Aug 11, 2019

Allow cross-compiling doctests #60387

Merged

Use panic::set_hook to print the ICE message #60584

Merged

bors merged commit 4229dc3 into rust-lang:master Aug 11, 2019

bors mentioned this pull request Aug 11, 2019

Support impl Trait in inlined documentation #61613

Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #63471

Rollup of 8 pull requests #63471

Mark-Simulacrum commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019

Rollup of 8 pull requests #63471

Rollup of 8 pull requests #63471

Conversation

Mark-Simulacrum commented Aug 11, 2019

Mark-Simulacrum commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019

bors commented Aug 11, 2019