Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #63554

Closed
wants to merge 42 commits into from
Closed

Commits on Jul 28, 2019

  1. Configuration menu
    Copy the full SHA
    3b229f1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5800bec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3677c5b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e4c39e1 View commit details
    Browse the repository at this point in the history
  5. fix tests

    RalfJung committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    388d99d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    74fbdb6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    647c0e0 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. rustc: implement argsfiles for command line

    This makes `rustc` support `@path` arguments on the command line. The `path` is opened and the file is interpreted
    as new command line options which are logically inserted at that point in the command-line. The options in the file
    are one per line. The file is UTF-8 encoded, and may have either Unix or Windows line endings.
    It does not support recursive use of `@path`.
    
    This is useful for very large command lines, or when command-lines are being generated into files by other tooling.
    jsgf committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    f0e3258 View commit details
    Browse the repository at this point in the history
  2. Use named arguments for formatting usage message.

    It was getting a bit awkward.
    jsgf committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    a0dbeea View commit details
    Browse the repository at this point in the history
  3. Use BufReader::lines() to parse out the lines

    It already imlements the right behaviour, and it saves us implementing the state machine.
    jsgf committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    4fc66a7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    892ae41 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2019

  1. Configuration menu
    Copy the full SHA
    a4af9d1 View commit details
    Browse the repository at this point in the history
  2. extract parse_pat_deref

    Centril committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    90793c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c69b3ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b65133 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    231da7e View commit details
    Browse the repository at this point in the history
  6. extract parse_pat_mac_invoc

    Centril committed Aug 12, 2019
    Configuration menu
    Copy the full SHA
    e32bd69 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e6f980f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    49740b7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    37f37a5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ddf734d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c8fc4c1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    71415ef View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    2f6cb5f View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    76a1345 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c037597 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    2882bee View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    22127b1 View commit details
    Browse the repository at this point in the history
  18. Fix indentation nit in src/librustc/mir/mod.rs.

    Co-Authored-By: bjorn3 <bjorn3@users.noreply.github.com>
    eddyb and bjorn3 authored Aug 12, 2019
    Configuration menu
    Copy the full SHA
    d30f481 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. Configuration menu
    Copy the full SHA
    13fd466 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    376636e View commit details
    Browse the repository at this point in the history
  3. Simplify by removing FileArgs

    jsgf committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    b5404f0 View commit details
    Browse the repository at this point in the history
  4. review comment: move test

    estebank committed Aug 13, 2019
    Configuration menu
    Copy the full SHA
    25d507f View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2019

  1. Configuration menu
    Copy the full SHA
    9348af8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#62984 - nathanwhit:extra_semi_lint, r=varkor

    Add lint for excess trailing semicolons
    
    Closes rust-lang#60876.
    A caveat (not necessarily a negative, but something to consider) with this implementation is that excess semicolons after return/continue/break now also cause an 'unreachable statement' warning.
    
    For the following example:
    ```
    fn main() {
        extra_semis();
    }
    fn extra_semis() -> i32 {
        let mut sum = 0;;;
        for i in 0..10 {
            if i == 5 {
                continue;;
            } else if i == 9 {
                break;;
            } else {
                sum += i;;
            }
        }
        return sum;;
    }
    ```
    The output is:
    ```
    warning: unnecessary trailing semicolons
     --> src/main.rs:5:21
      |
    5 |     let mut sum = 0;;;
      |                     ^^ help: remove these semicolons
      |
      = note: `#[warn(redundant_semicolon)]` on by default
    
    warning: unnecessary trailing semicolon
     --> src/main.rs:8:22
      |
    8 |             continue;;
      |                      ^ help: remove this semicolon
    
    warning: unnecessary trailing semicolon
      --> src/main.rs:10:19
       |
    10 |             break;;
       |                   ^ help: remove this semicolon
    
    warning: unnecessary trailing semicolon
      --> src/main.rs:12:22
       |
    12 |             sum += i;;
       |                      ^ help: remove this semicolon
    
    warning: unnecessary trailing semicolon
      --> src/main.rs:15:16
       |
    15 |     return sum;;
       |                ^ help: remove this semicolon
    
    warning: unreachable statement
     --> src/main.rs:8:22
      |
    8 |             continue;;
      |                      ^
      |
      = note: `#[warn(unreachable_code)]` on by default
    
    warning: unreachable statement
      --> src/main.rs:10:19
       |
    10 |             break;;
       |                   ^
    
    warning: unreachable statement
      --> src/main.rs:15:16
       |
    15 |     return sum;;
       |                ^
    
    ```
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    902cfac View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#63075 - RalfJung:deref-checks, r=oli-obk

    Miri: Check that a ptr is aligned and inbounds already when evaluating `*`
    
    This syncs Miri with what the Nomicon and the Reference say, and resolves rust-lang/miri#447.
    
    Also this would not have worked without rust-lang#62982 due to new cycles. ;)
    
    r? @oli-obk
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    2697a29 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#63175 - jsgf:argsfile, r=alexcrichton

    rustc: implement argsfiles for command line
    
    Many tools, such as gcc and gnu-ld, support "args files" - that is, being able to specify @file on the command line.  This causes `file` to be opened and parsed for command line options. They're separated with whitespace; whitespace can be quoted with double or single quotes, and everything can be \\-escaped. Args files may recursively include other args files via `@file2`.
    
    See https://sourceware.org/binutils/docs/ld/Options.html#Options for the documentation of gnu-ld's @file parameters.
    
    This is useful for very large command lines, or when command lines are being generated into files by other tooling.
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    91e48b5 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#63490 - Centril:cleanup-pat-parser, r=petro…

    …chenkov
    
    libsyntax: cleanup and refactor `pat.rs`
    
    A smaller refactoring & cleanup of `pat.rs` (best read commit by commit).
    
    r? @petrochenkov
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    a607786 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#63495 - eddyb:mir-constant-ty, r=oli-obk

     Remove redundant `ty` fields from `mir::Constant` and `hair::pattern::PatternRange`.
    
    Fixes rust-lang#56137.
    
    As a side-effect, associated const literals have the correct type now, which should make things easier for rust-lang#61041.
    
    r? @oli-obk / @matthewjasper cc @davidtwco @varkor
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    baab604 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#63509 - estebank:async-span, r=Centril

    Point at the right enclosing scope when using `await` in non-async fn
    
    Fix rust-lang#63398.
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    3c08dfc View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#63528 - petrochenkov:anyany, r=estebank

    syntax: Remove `DummyResult::expr_only`
    
    The effect is that if a built-in macro both returns an erroneous AST fragment and is used in unexpected position, then the incorrect position error won't be reported.
    
    This combination of two errors should be rare and isn't worth an extra field that makes people ask questions in comments.
    (There wasn't even a test making sure it worked.)
    
    Addresses rust-lang#63468 (comment)
    r? @estebank
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    159efeb View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#63542 - c410-f3r:node_ids, r=petrochenkov

    Add NodeId for Arm, Field and FieldPat
    
    Extracted from rust-lang#63468
    Centril authored Aug 14, 2019
    Configuration menu
    Copy the full SHA
    82f2dad View commit details
    Browse the repository at this point in the history