Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error message for break in async block #63659

Merged
merged 1 commit into from
Aug 18, 2019
Merged

Improved error message for break in async block #63659

merged 1 commit into from
Aug 18, 2019

Conversation

gilescope
Copy link
Contributor

@gilescope gilescope commented Aug 17, 2019 •
edited by Centril
Loading

Fixes #63391

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2019
@gilescope gilescope changed the title Less confusing error message. Improved error message for break in async block Aug 17, 2019
@Centril
Copy link
Contributor

Centril commented Aug 17, 2019

r? @Centril

r=me rollup with comment addressed.

@rust-highfive rust-highfive assigned Centril and unassigned varkor Aug 17, 2019
@Centril
Copy link
Contributor

Centril commented Aug 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Aug 18, 2019

📌 Commit 1e02bc6 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 18, 2019
@Centril
Rollup merge of rust-lang#63659 - gilescope:async-in-closure, r=Centril
787a883 
Improved error message for break in async block

Fixes rust-lang#63391
@Centril Centril mentioned this pull request Aug 18, 2019
Closed
@bors
Copy link
Contributor

bors commented Aug 18, 2019

⌛ Testing commit 1e02bc6 with merge 4cf7673...

bors added a commit that referenced this pull request Aug 18, 2019
@bors
Auto merge of #63659 - gilescope:async-in-closure, r=Centril
4cf7673 
Improved error message for break in async block

Fixes #63391
@bors
Copy link
Contributor

bors commented Aug 18, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 4cf7673 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2019
@bors bors merged commit 1e02bc6 into rust-lang:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@Centril Centril

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve diagnostic for break in async { ... } block
5 participants
@gilescope @rust-highfive @Centril @bors @varkor