libstd fuchsia fixes #64023
Merged
libstd fuchsia fixes #64023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
cramertj
reviewed
Aug 30, 2019
| @@ -301,6 +314,7 @@ impl Stdio { | |||
| Ok((ChildStdio::Owned(theirs.into_fd()), Some(ours))) | |||
| } | |||
|
|
|||
| #[cfg(not(target_os = "fuchsia"))] | |||
There was a problem hiding this comment.
I'm not in love with these inline cfgs, but they seem to match the way redox was treated above, and I don't think this would be more cleanly expressed via a separate file. 🤷♀️
|
LGTM-- why is this tagged WIP? |
Because I hit another issue with this implementation.. update coming soon! |
|
@bors r+ |
|
📌 Commit 5f91ad0 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 4, 2019
…mertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj
bors
added a commit
that referenced
this pull request
Sep 4, 2019
Rollup of 10 pull requests Successful merges: - #63166 (Add Result::cloned{,_err} and Result::copied{,_err}) - #63930 (Account for doc comments coming from proc macros without spans) - #63985 (Stabilize pin_into_inner in 1.39.0) - #64023 (libstd fuchsia fixes) - #64030 (Fix unlock ordering in SGX synchronization primitives) - #64041 (use TokenStream rather than &[TokenTree] for built-in macros) - #64043 (Add some more tests for underscore imports) - #64092 (Update xLTO compatibility table in rustc book.) - #64120 (Move path parsing earlier) - #64123 (Added warning around code with reference to uninit bytes) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
…mertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj
alexcrichton
reviewed
Sep 5, 2019
| use crate::sys::pipe::{self, AnonPipe}; | ||
| use crate::sys_common::process::{CommandEnv, DefaultEnvKey}; | ||
| use crate::collections::BTreeMap; | ||
|
|
||
| #[cfg(not(target_os = "fuchsia"))] |
There was a problem hiding this comment.
Since this file is shared amongst most platforms, would it be possible to avoid the fuchsia-specific cfgs? Could Null be used on all platforms and only at the very end it's lowered to /dev/null?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
…mertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
…mertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj
|
⌛ Testing commit 5f91ad0 with merge 0c5c836ae77483667ac410b7ffcf9969e5298a9e... |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
…mertj libstd fuchsia fixes This fixes two bugs in libstd on Fuchsia: - `zx_time_t` was changed to an `i64`, but this never made it into libstd - When spawning processes where any of the stdio were null, libstd attempts to open `/dev/null`, which doesn't exist on Fuchsia r? @cramertj
|
@bors retry rolled up. |
bors
added a commit
that referenced
this pull request
Sep 7, 2019
Rollup of 7 pull requests Successful merges: - #64023 (libstd fuchsia fixes) - #64098 (Ensure edition lints and internal lints are enabled with deny-warnings=false) - #64139 (Migrate internal diagnostic registration to macro_rules) - #64226 (Aggregation of cosmetic changes made during work on REPL PRs: libsyntax) - #64227 (Aggregation of cosmetic changes made during work on REPL PRs: librustc) - #64235 (Upgrade env_logger to 0.6) - #64258 (compiletest: Match suffixed environments) Failed merges: r? @ghost
|
Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs in libstd on Fuchsia:
zx_time_twas changed to ani64, but this never made it into libstd/dev/null, which doesn't exist on Fuchsiar? @cramertj