Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On obligation errors point at the unfulfilled binding when possible #64151

Merged
merged 10 commits into from
Sep 23, 2019
Merged

On obligation errors point at the unfulfilled binding when possible #64151

merged 10 commits into from
Sep 23, 2019

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 4, 2019 •
edited
Loading

CC #42855, #64130, #64135. Fix #61860.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019
@estebank
Copy link
Contributor Author

estebank commented Sep 4, 2019

CC @nikomatsakis @Centril, I'd like a couple of extra eyes to make sure I'm not pointing at the wrong binding accidentally.

@rust-highfive

This comment has been minimized.

Sign in to view
@estebank estebank force-pushed the binding-error branch 2 times, most recently from 6e5a280 to 07ea946 Compare September 4, 2019 19:27
Centril
Centril reviewed Sep 5, 2019
View reviewed changes
src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
src/librustc/hir/mod.rs Outdated Show resolved Hide resolved
src/librustc/traits/error_reporting.rs Show resolved Hide resolved
src/librustc_typeck/check/mod.rs Outdated Show resolved Hide resolved
src/libsyntax/parse/parser/path.rs Outdated Show resolved Hide resolved
@estebank

This comment has been minimized.

Sign in to view
@varkor
Copy link
Member

varkor commented Sep 10, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Sep 10, 2019

📌 Commit 3109b1f47891a11037e446a5809bf385f5326b12 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2019
@bors

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 11, 2019
@estebank
Copy link
Contributor Author

Inconsistent output across multiple targets strikes again. CC #53081, @oli-obk I can't find the issue you recently pinged me in that tracked this exact issue.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 11, 2019

Sorry on mobile until Friday. I don't know where it was

@estebank
Copy link
Contributor Author

I believe this might be the same as #46948

@estebank estebank mentioned this pull request Sep 16, 2019
Merged
@estebank

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2019
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2019
@estebank
Copy link
Contributor Author

Progress: fixed the NLL tests.

@bors r=varkor

@bors
Copy link
Contributor

bors commented Sep 22, 2019

📌 Commit ff75124 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2019
@bors
Copy link
Contributor

bors commented Sep 22, 2019

⌛ Testing commit ff75124 with merge c0b7e71...

bors added a commit that referenced this pull request Sep 22, 2019
@bors
Auto merge of #64151 - estebank:binding-error, r=varkor
c0b7e71 
On obligation errors point at the unfulfilled binding when possible

CC #42855, #64130, #64135. Fix #61860.
@bors
Copy link
Contributor

bors commented Sep 23, 2019

☀️ Test successful - checks-azure
Approved by: varkor
Pushing c0b7e71 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 23, 2019
@bors bors merged commit ff75124 into rust-lang:master Sep 23, 2019
@estebank estebank mentioned this pull request Oct 18, 2019
Merged
@jebrosen jebrosen mentioned this pull request Oct 27, 2019
Closed
@RalfJung RalfJung mentioned this pull request Nov 2, 2019
Merged
@jebrosen jebrosen mentioned this pull request Nov 6, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 7, 2019
@Centril
Rollup merge of rust-lang#66049 - RalfJung:missing-spans, r=alexcrichton
aa71057 
consistent handling of missing sysroot spans

Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue.

I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 8, 2019
@JohnTitor
Rollup merge of rust-lang#66049 - RalfJung:missing-spans, r=alexcrichton
9dc5d0e 
consistent handling of missing sysroot spans

Due to rust-lang#53081, sysroot spans (pointing to code in libcore/libstd/...) fails to print on some x86 runners. This consolidates the ignore directives for that and references the relevant issue.

I also did that for the generated derive-error-span tests -- but there the script and the tests were not entirely in sync any more since rust-lang#64151. Cc @estebank @varkor
@jebrosen jebrosen mentioned this pull request Nov 9, 2019
Open
@csmoe csmoe mentioned this pull request Nov 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

Assignees

@varkor varkor

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"doesn't have a size known at compile-time" should underline the type, not the whole size_of function
8 participants
@estebank @rust-highfive @varkor @bors @oli-obk @Centril @mati865 @RalfJung