-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use backtrace formatting from the backtrace crate #64152
Conversation
Probably want to block on rust-lang/backtrace-rs#247 so we can clean this up before landing. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
9a02e65
to
fe70c3c
Compare
I've published the next version with that PR, I'll take a closer look at this in an hour or so |
fe70c3c
to
118d21a
Compare
I've updated this to use 1.37, thanks for the quick turnaround on that PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks!
118d21a
to
3490c10
Compare
3490c10
to
290f5b2
Compare
@bors: r+ |
📌 Commit 290f5b2 has been approved by |
…ichton Use backtrace formatting from the backtrace crate r? @alexcrichton
Rollup of 4 pull requests Successful merges: - #62205 (Add Iterator comparison methods that take a comparison function) - #64152 (Use backtrace formatting from the backtrace crate) - #64265 (resolve: Mark more erroneous imports as used) - #64267 (rustdoc: fix diagnostic with mixed code block styles) Failed merges: r? @ghost
☔ The latest upstream changes (presumably #64281) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @alexcrichton