Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backtrace formatting from the backtrace crate #64152

Merged
merged 1 commit into from
Sep 8, 2019

Conversation

cramertj
Copy link
Member

@cramertj cramertj commented Sep 4, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 4, 2019
@cramertj
Copy link
Member Author

cramertj commented Sep 4, 2019

Probably want to block on rust-lang/backtrace-rs#247 so we can clean this up before landing.

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-04T19:16:04.3140385Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-04T19:16:04.3356311Z ##[command]git config gc.auto 0
2019-09-04T19:16:05.2379149Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-04T19:16:05.2383760Z ##[command]git config --get-all http.proxy
2019-09-04T19:16:05.2389305Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64152/merge:refs/remotes/pull/64152/merge
---
2019-09-04T19:23:01.8269607Z    Compiling serde_json v1.0.40
2019-09-04T19:23:03.6824768Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-09-04T19:23:14.9417052Z     Finished release [optimized] target(s) in 1m 31s
2019-09-04T19:23:14.9504758Z tidy check
2019-09-04T19:23:15.8066351Z tidy error: /checkout/src/libstd/sys_common/backtrace.rs:40: TODO is deprecated; use FIXME
2019-09-04T19:23:16.9466348Z some tidy checks failed
2019-09-04T19:23:16.9471447Z 
2019-09-04T19:23:16.9471447Z 
2019-09-04T19:23:16.9477319Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-09-04T19:23:16.9479168Z 
2019-09-04T19:23:16.9479250Z 
2019-09-04T19:23:16.9479310Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-09-04T19:23:16.9479365Z Build completed unsuccessfully in 0:01:35
2019-09-04T19:23:16.9479365Z Build completed unsuccessfully in 0:01:35
2019-09-04T19:23:16.9535964Z == clock drift check ==
2019-09-04T19:23:16.9551910Z   local time: Wed Sep  4 19:23:16 UTC 2019
2019-09-04T19:23:17.1116280Z   network time: Wed, 04 Sep 2019 19:23:17 GMT
2019-09-04T19:23:17.1116480Z == end clock drift check ==
2019-09-04T19:23:18.4239487Z ##[error]Bash exited with code '1'.
2019-09-04T19:23:18.4275643Z ##[section]Starting: Checkout
2019-09-04T19:23:18.4277250Z ==============================================================================
2019-09-04T19:23:18.4277295Z Task         : Get sources
2019-09-04T19:23:18.4277334Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton
Copy link
Member

I've published the next version with that PR, I'll take a closer look at this in an hour or so

@cramertj
Copy link
Member Author

cramertj commented Sep 4, 2019

Probably want to block on rust-lang/backtrace-rs#247 so we can clean this up before landing.

I've published the next version with that PR, I'll take a closer look at this in an hour or so

I've updated this to use 1.37, thanks for the quick turnaround on that PR!

Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks!

src/libstd/sys_common/backtrace.rs Outdated Show resolved Hide resolved
src/libstd/sys_common/backtrace.rs Outdated Show resolved Hide resolved
src/libstd/sys_common/backtrace.rs Outdated Show resolved Hide resolved
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 4, 2019

📌 Commit 290f5b2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Sep 8, 2019
…ichton

Use backtrace formatting from the backtrace crate

r? @alexcrichton
bors added a commit that referenced this pull request Sep 8, 2019
Rollup of 4 pull requests

Successful merges:

 - #62205 (Add Iterator comparison methods that take a comparison function)
 - #64152 (Use backtrace formatting from the backtrace crate)
 - #64265 (resolve: Mark more erroneous imports as used)
 - #64267 (rustdoc: fix diagnostic with mixed code block styles)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Sep 8, 2019

☔ The latest upstream changes (presumably #64281) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 8, 2019
@bors bors merged commit 290f5b2 into rust-lang:master Sep 8, 2019
@cramertj cramertj deleted the update-backtrace branch September 9, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants