Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Added more prereqs and note about default directory #64241

Merged
merged 1 commit into from
Sep 7, 2019
Merged

[doc] Added more prereqs and note about default directory #64241

merged 1 commit into from
Sep 7, 2019

Conversation

aditya4d
Copy link
Contributor

@aditya4d aditya4d commented Sep 6, 2019

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 6, 2019
@aditya4d aditya4d changed the title Added more prereqs and note about default directory [doc] Added more prereqs and note about default directory Sep 6, 2019
@Centril
Copy link
Contributor

Centril commented Sep 6, 2019

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Sep 6, 2019

📌 Commit 7dd5c66 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2019
@aditya4d
Copy link
Contributor Author

aditya4d commented Sep 6, 2019

How to merge it?

@Mark-Simulacrum
Copy link
Member

It'll be merged by bors soon, see https://buildbot2.rust-lang.org/homu/queue/rust for queue.

Centril added a commit to Centril/rust that referenced this pull request Sep 7, 2019
@Centril
Rollup merge of rust-lang#64241 - adityaatluri:install-doc, r=Mark-Si…
69121f5 
…mulacrum

[doc] Added more prereqs and note about default directory
@Centril Centril mentioned this pull request Sep 7, 2019
Merged
bors added a commit that referenced this pull request Sep 7, 2019
@bors
Auto merge of #64246 - Centril:rollup-zey4o09, r=Centril
ef54f57 
Rollup of 10 pull requests

Successful merges:

 - #63919 (Use hygiene for AST passes)
 - #63927 (Filter linkcheck spurious failure)
 - #64149 (rustc_codegen_llvm: give names to non-alloca variable values.)
 - #64192 (Bail out when encountering likely missing turbofish in parser)
 - #64231 (Move the HIR CFG to `rustc_ast_borrowck`)
 - #64233 (Correct pluralisation of various diagnostic messages)
 - #64236 (reduce visibility)
 - #64240 (Include compiler-rt in the source tarball)
 - #64241 ([doc] Added more prereqs and note about default directory)
 - #64243 (Move injection of attributes from command line to `libsyntax_ext`)

Failed merges:

r? @ghost
@bors bors merged commit 7dd5c66 into rust-lang:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aditya4d @rust-highfive @Centril @Mark-Simulacrum @bors @nikomatsakis