Warn on no_start, crate_id attribute use #64471
Conversation
|
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'm not marking as relnotes as these attributes have done nothing since pre-1.0 so there's no compatibility note that I think we should issue. |
|
Could we try cratering the removal? Maybe no one actually uses it and we can remove some tech debt. |
|
The tech debt is so minimal that it doesn't seem worth it, but if you'd like me to I can delete the attributes and we can run crater on that PR. Up to you. |
|
@Mark-Simulacrum I just checked and I agree that the tech debt is very minimal (basically 4 boilerplate lines in total). Let's deprecate for now. |
These attributes are now deprecated; they don't have any use anymore.
Mark-Simulacrum
force-pushed
the
warn-depr-attr
branch
from
80d0fa6 to
a0e48b6
Compare
|
Alright, updated, extracting the function to avoid duplicating the suggestion. |
|
@rust-lang/lang N.B. this deprecates two attributes that have had no effect in ages per the description in the PR... This could ostensibly be FCPed but I'm dispensing with this because it I expect the PR will be wildly uncontroversial. Nonethless, here's a heads-up. @bors r+ rollup |
|
📌 Commit a0e48b6 has been approved by |
bors
added
S-waiting-on-bors
…entril Warn on no_start, crate_id attribute use These attributes are now deprecated; they don't have any use anymore. `no_start` stopped being applicable in 3ee916e as part of rust-lang#18967. Ideally we would've removed it pre-1.0, but since that didn't happen let's at least mark it deprecated. `crate_id` was renamed to `crate_name` in 50ee1ec as part of rust-lang#15319. Ideally we would've followed that up with a removal of crate_id itself as well, but that didn't happen; this PR finally marks it as deprecated at least. Fixes rust-lang#43142 and resolves rust-lang#43144.
Rollup of 5 pull requests Successful merges: - #64457 (def_collector: Do not ICE on attributes on unnamed fields) - #64463 (resolve: Tweak some expected/found wording) - #64471 (Warn on no_start, crate_id attribute use) - #64473 (Use try_fold instead of manually carrying an accumulator) - #64475 (simplify the initialization) Failed merges: r? @ghost
remove long-deprecated no-op attributes no_start and crate_id These have emitted a deprecation warning since forever (rust-lang#64471) and they already don't do anything.
These attributes are now deprecated; they don't have any use anymore.
no_startstopped being applicable in 3ee916e as part of #18967. Ideally we would've removed it pre-1.0, but since that didn't happen let's at least mark it deprecated.crate_idwas renamed tocrate_namein 50ee1ec as part of #15319. Ideally we would've followed that up with a removal of crate_id itself as well, but that didn't happen; this PR finally marks it as deprecated at least.Fixes #43142 and resolves #43144.