[WIP-test run] switch rustc allocator to mimalloc #64495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…malloc from being enabled
|
@bors: try |
|
@gnzlbg: 🔑 Insufficient privileges: not in try users |
|
@bors try |
|
⌛ Trying commit 111e3f8 with merge 606331a2236eca07e80368668ab5c7b97d68c300... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
the
S-waiting-on-author
|
The mimalloc maintainers were finally able to reproduce our segfaults, so i'm closing this again since no progress can happen here until those issues are resolved. @Mark-Simulacrum there is currently a big barrier of entry to debug rustc issues. I think it would be worth documenting how to run rustc build locally in the exact same way that CI does (e.g. using docker as @mati865 explains microsoft/mimalloc#77 ). Also, when running a test fails, there is no easy way to debug it in the same conditions that CI has, and e.g., just launch gdb/lldb/valgrind/etc. on the test. One currently gets the CLI invocation for the command that fails, but this does not includes all the environment variables required to run that command correctly, see this comment: microsoft/mimalloc#77 (comment) |
|
Now that daanx figured out what was happening in microsoft/mimalloc#77 (comment) , is it worth retrying? |
|
I think it is. A new test run has been opened in #81782 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #62340 . Disables secure mode.
r? @mati865