build-manifest: re-add some comments #64544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Merged
RalfJung
force-pushed
the
build-manifest
branch
from
12a89d5 to
a4dc33b
Compare
|
Rebased as #64543 landed. |
|
@bors r+ rollup |
|
📌 Commit a4dc33b has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Sep 17, 2019
…bini build-manifest: re-add some comments rust-lang#64543 also reverted the comments I added. This adds them back. Includes rust-lang#64543. r? @pietroalbini
bors
added a commit
that referenced
this pull request
Sep 17, 2019
Rollup of 10 pull requests Successful merges: - #61626 (Get rid of special const intrinsic query in favour of `const_eval`) - #64283 (Updated RELEASES.md for 1.38.0) - #64394 (Shrink `SubregionOrigin`.) - #64429 (Fix failure note `to_str` implementation) - #64436 (improve Vec example soundness in mem::transmute docs) - #64502 (avoid duplicate issues for Miri build failures) - #64505 (Fix inconsistent link formatting) - #64529 (Add an example to Pin::as_mut) - #64541 (document Miri error categories) - #64544 (build-manifest: re-add some comments) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64543 also reverted the comments I added. This adds them back.
Includes #64543.
r? @pietroalbini