Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #64687

Closed
wants to merge 59 commits into from
Closed

Commits on Sep 8, 2019

  1. Fix Stdio::piped example code and lint

    Summary:
    Invoking `rev` does not add a trailing newline when none is present in
    the input (at least on my Debian). Nearby examples use `echo` rather
    than `rev`, which probably explains the source of the discrepancy.
    
    Also, a `mut` qualifier is unused.
    
    Test Plan:
    Copy the code block into <https://play.rust-lang.org> with a `fn main`
    wrapper, and run it. Note that it compiles and runs cleanly; prior to
    this commit, it would emit an `unused_mut` warning and then panic.
    
    wchargin-branch: stdio-piped-docs
    wchargin committed Sep 8, 2019
    Configuration menu
    Copy the full SHA
    9bf5773 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Configuration menu
    Copy the full SHA
    612ef5f View commit details
    Browse the repository at this point in the history
  2. change to check-pass

    nikomatsakis committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    e69d1b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2019

  1. Configuration menu
    Copy the full SHA
    146cb8e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2f903c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6579d13 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    75fb42a View commit details
    Browse the repository at this point in the history
  5. check_match: misc cleanup.

    Centril committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    89bbef3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4c34693 View commit details
    Browse the repository at this point in the history
  7. simplify hir::Pat::walk_.

    Centril committed Sep 15, 2019
    Configuration menu
    Copy the full SHA
    9d1c3c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2019

  1. Configuration menu
    Copy the full SHA
    cc5fe6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ca42a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    57eeb61 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb2cfec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d7139f3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    07deb93 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    0dfd706 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    38a5ae9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9b406f1 View commit details
    Browse the repository at this point in the history
  10. or-patterns: check_match: remove top_pats_hack for `check_for_bindi…

    …ngs_named_same_as_variants`.
    Centril committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    6bd8c6d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    549756b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    56b055a View commit details
    Browse the repository at this point in the history
  13. or-patterns: liveness: is_argument -> is_param.

    Pacify `tidy`. It's also more correct in this context.
    Centril committed Sep 16, 2019
    Configuration menu
    Copy the full SHA
    05cc3c0 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    370fbcc View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Configuration menu
    Copy the full SHA
    3f004a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Add more tests

    weiznich committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    a9c38d9 View commit details
    Browse the repository at this point in the history
  2. Split line to fix tidy

    weiznich committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    31b3012 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Support run-fail ui tests

    tmandry committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    e625f62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78ff110 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    52e4919 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c6b4fb7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    df24055 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e6015e4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c792c25 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    c396c12 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    6f36f87 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9c2d227 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8233b28 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2019

  1. or-patterns: middle/dead: remove top_pats_hack.

    Also tweak walkers on `Pat`.
    Centril committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    0918dc4 View commit details
    Browse the repository at this point in the history
  2. Remove constraints argument from path_all

    It was never used
    Mark-Simulacrum committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    67d88f6 View commit details
    Browse the repository at this point in the history
  3. Remove unused code

    Mark-Simulacrum committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    2aa9d29 View commit details
    Browse the repository at this point in the history
  4. Inline ty_infer

    Mark-Simulacrum committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    e41aa8c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8417ac6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3e6b844 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2019

  1. Configuration menu
    Copy the full SHA
    60560bc View commit details
    Browse the repository at this point in the history
  2. remove outdated comment

    tshepang committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    c3d7917 View commit details
    Browse the repository at this point in the history
  3. review comments

    estebank committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    daed674 View commit details
    Browse the repository at this point in the history
  4. review comments: wording

    estebank committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    0f2f16d View commit details
    Browse the repository at this point in the history
  5. Infer consts consistently. Moved some logic into super_combined_consts,

    also removed some duplicated logic from TypeRelation methods.
    skinnyBat committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    3f2855e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3ee2920 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64158 - tmandry:libtest-panic-abort, r=alex…

    …crichton
    
    panic=abort support in libtest
    
    Add experimental support for tests compiled with panic=abort. Enabled with `-Z panic_abort_tests`.
    
    r? @alexcrichton
    cc @cramertj
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    43f291c View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#64294 - wchargin:wchargin-stdio-piped-docs,…

    … r=Dylan-DPC
    
    Fix `Stdio::piped` example code and lint
    
    Summary:
    Invoking `rev` does not add a trailing newline when none is present in
    the input (at least on my Debian). Nearby examples use `echo` rather
    than `rev`, which probably explains the source of the discrepancy.
    
    Also, a `mut` qualifier is unused.
    
    Test Plan:
    Copy the code block into <https://play.rust-lang.org> with a `fn main`
    wrapper, and run it. Note that it compiles and runs cleanly; prior to
    this commit, it would emit an `unused_mut` warning and then panic.
    
    wchargin-branch: stdio-piped-docs
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    f8d12dc View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#64508 - Centril:or-pat-hir, r=matthewjasper

    or-patterns: Push `PatKind/PatternKind::Or` at top level to HIR & HAIR
    
    Following up on work in rust-lang#64111, rust-lang#63693, and rust-lang#61708, in this PR:
    
    - We change `hair::Arm.patterns: Vec<Pattern<'_>>` into `hir::Arm.pattern: Pattern<'_>`.
    
       - `fn hair::Arm::top_pats_hack` is introduced as a temporary crutch in MIR building to avoid more changes.
    
    - We change `hir::Arm.pats: HirVec<P<Pat>>` into `hir::Arm.pat: P<Pat>`.
    
       - The hacks in `rustc::hir::lowering` are removed since the representation hack is no longer necessary.
    
       - In some places, `fn hir::Arm::top_pats_hack` is introduced to leave some things as future work.
    
       - Misc changes: HIR pretty printing is adjusted to behave uniformly wrt. top/inner levels, rvalue promotion is adjusted, regionck, and dead_code is also.
    
       - Type checking is adjusted to uniformly handle or-patterns at top/inner levels.
          To make things compile, `p_0 | ... | p_n` is redefined as a "reference pattern" in [`fn is_non_ref_pat`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_typeck/check/struct.FnCtxt.html#method.is_non_ref_pat) for now. This is done so that reference types are not eagerly stripped from the `expected: Ty<'tcx>`.
    
        - Liveness is adjusted wrt. the `unused_variables` and `unused_assignments` lints to handle top/inner levels uniformly and the handling of `fn` parameters, `let` locals, and `match` arms are unified in this respect. This is not tested for now as exhaustiveness checks are reachable and will ICE.
    
        - In `check_match`, checking `@` and by-move bindings is adjusted. However, exhaustiveness checking is not adjusted the moment and is handled by @dlrobertson in rust-lang#63688.
    
        - AST borrowck (`construct.rs`) is not adjusted as AST borrowck will be removed soon.
    
    r? @matthewjasper
    cc @dlrobertson @varkor @oli-obk
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    c743912 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#64546 - weiznich:bugfix/rfc-2451-rerebalanc…

    …e-tests, r=nikomatsakis
    
    Bugfix/rfc 2451 rerebalance tests
    
    r? @nikomatsakis
    
    Fixes rust-lang#64412
    Depends/Contains on rust-lang#64414
    
    cc rust-lang#55437 and rust-lang#63599
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    2455f42 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#64670 - Mark-Simulacrum:ext-build-simplify,…

    … r=petrochenkov
    
    Cleanup syntax::ext::build
    
    I suspect most of this code could be inlined but I only removed the bits where the inlining didn't really hurt readability (i.e., method call -> function call) or the completely unused code.
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    18d1912 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#64674 - estebank:knock-down-the-wall, r=Cen…

    …tril
    
    Propagate `types.err` in locals further to avoid spurious knock-down errors
    
    Fix rust-lang#33575, fix rust-lang#44504.
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    f21b8ae View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#64676 - estebank:assoc-type-bound-in-generi…

    …c, r=petrochenkov
    
    Parse assoc type bounds in generic params and provide custom diagnostic
    
    Fix rust-lang#26271.
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    7c830ec View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#64677 - tshepang:outdated, r=Mark-Simulacrum

    remove outdated comment
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    ee2012c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#64679 - skinny121:const-infer, r=varkor

    Infer consts more consistently
    
    Moved some duplicated logic in `TypeRelation` methods into `super_combined_consts`. Before some `TypeRelation`s like `Lub` wasn't using `replace_if_possible`, meaning some inference types were staying around longer than they should be.
    
    Fixes rust-lang#64519
    
    r? @varkor
    Centril authored Sep 22, 2019
    Configuration menu
    Copy the full SHA
    afd1c60 View commit details
    Browse the repository at this point in the history